[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5319 Make sky

issue 5319: Make skylines reflect grob rotation

modified: ../lily/include/stencil.hh
Add parameter to skylines_from_stencil for rot (in analogy to pad)

modified: ../lily/stencil-integral.cc

Stencil::skylines_from_stencil
If new rotation parameter rot is specified, use a rotated copy of
the original stencil to build the skyline transformation matrix.
As the rotation is rarely used, the general (non-rotated) case will
still use the original stencil as before.

Grob::vertical_sklyines_from_grob and Grob::horizontal_skylines_from_grob
Read "rotation" property an pass it (SCM) to skylines_from_stencil.

modified: ../lily/accidental.cc

Accidental_interface::horizontal_skylines
Read "rotation" property and pass it (SCM) to skylines_from_stencil.

Announced in ../Documentation/changes.tely

Documentation example slightly adapted (20° to 15°) to new skyline
behaviour (padding will now be respected). In all affected languages:
modified: ../Documentation/de/notation/changing-defaults.itely
modified: ../Documentation/es/notation/changing-defaults.itely
modified: ../Documentation/fr/notation/changing-defaults.itely
modified: ../Documentation/it/notation/changing-defaults.itely
modified: ../Documentation/ja/notation/changing-defaults.itely
modified: ../Documentation/notation/changing-defaults.itely

modified: ../input/regression/skyline-color-rotation.ly
(20° to 15°, cf. documentation)

new: ../input/regression/skyline-grob-rotation.ly
New regression test.

issue 5312: Key cancellation glyph position inconsistent

file lily/key-signature-interface.cc

Now using two intervals representing the "vertical skylines" of two
adjacent natural glyphs. This makes a better model of the actual glyph
shape than the original single point within an inverval.
Now we can distiguish between all three cases:
(1) no overlap -> no additional kerning needed
(2) just touching (overlap, but intesection length 0) -> kerning 0.15
(3) overlapping -> kerning 0.3

Case (2) is the new one that couldn't be handled before:
Just touching at the corners made the glyphs cling together.

Using same interval technique as before, but I renamed the Slices from
pos and overlap_pos to
ht_right and last_ht_left.
Using quarter stave-spaces as to get a better (integer) resolution.

http://codereview.appspot.com/342060043

[issues:#5319] Make skylines reflect grob rotation

Status: Started
Created: Thu May 03, 2018 11:44 AM UTC by Torsten Hämmerle
Last Updated: Thu May 03, 2018 12:34 PM UTC
Owner: Torsten Hämmerle
Attachments:

skyline-grob-rotation.png (59.4 kB; image/png)

As has been agreed in thread http://lilypond.1069038.n5.nabble.com/Skylines-and-certain-grob-properties-rotation-extra-offset-tt212002.html, skylines should reflect the grobs' "rotation" property.

The "rotation" property (grob-interface) will be applied to the stencil after skylines have been built. Therefore, the skylines currently do not know about grob rotation and stoically stay in place.

In the example PNG file, you can see the original skylines on the left compared to the enhanced skylines on the right:

Hairpins now actually get "out of the way" when being rotated (vertical skylines)
Note the distance of the hairpin to the stave: padding is respected due to more realistic skylines.
TextScripts now align as they should
Accidentals: The two sharps now will be placed directly above and below one another because they take up less vertical space when rotated (horizontal skylines)

All the best,
Torsten

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5319 Make skylines reflect grob rotation
Date:	Thu, 03 May 2018 12:35:01 -0000