lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5084 Create B


From: Auto mailings of changes to Lily Issues
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5084 Create Bracket class
Date: Mon, 13 Mar 2017 18:35:03 +0000

Diff:

--- old
+++ new
@@ -1,4 +1,4 @@
-Create Bracket class
+Issue 5084: Create Bracket class

 Code involving brackets suffers from two confusing
 organizational issues:

Pushed to staging as

author David Nalesnik address@hidden
Thu, 23 Feb 2017 10:57:44 -0500 (09:57 -0600)
committer David Nalesnik address@hidden
Mon, 13 Mar 2017 13:15:50 -0500 (13:15 -0500)
commit 9e877e5aea3fb6cf6e7873d1e8797672cda450f5


[issues:#5084] Create Bracket class

Status: Fixed
Labels: Fixed_2_19_57
Created: Mon Mar 06, 2017 04:38 PM UTC by David Nalesnik
Last Updated: Mon Mar 13, 2017 03:45 PM UTC
Owner: David Nalesnik

Issue 5084: Create Bracket class

Code involving brackets suffers from two confusing
organizational issues:

(1) Tuplet_bracket::make_bracket is used to create brackets
for a number of grobs: BassFigureBracket, HorizontalBracket,
OttavaBracket, PianoPedalBracket, VoltaBracket, along with
TupletBracket

(2) Methods belonging to Horizontal_bracket are used to draw
both horizonal brackets (HorizontalBracket) and vertical
brackets (BassFigureBracket)

To remedy this, a new Bracket class is created.

This new class contains the old Tuplet_bracket::make_bracket,
Horizontal_bracket::make_bracket, and
Horizontal_bracket::make_enclosing_bracket.

These methods have been renamed to clarify their purpose.

http://codereview.appspot.com/314610043


Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

reply via email to

[Prev in Thread] Current Thread [Next in Thread]