[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5086 Fix dashed line errors

[Auto mailings of changes to Lily Issues]

• Patch: countdown --> push
• Comment:

@David Nalesnik
If you want to push this, go ahead and create a new tracker for a reg test as per David Kastrup's suggestion, or you can tag the reg test on this issue (in which case just make sure it goes to the correct state so I can spot it to test).

I'll set this to 'Counted down please push' for now.

James

---

[issues:#5086] Fix dashed line errors

Status: Started
Created: Tue Mar 07, 2017 04:45 AM UTC by David Nalesnik
Last Updated: Mon Mar 13, 2017 11:24 AM UTC
Owner: David Nalesnik

Fix dashed line errors

There are two errors in lily/line-interface.cc which cause
dashed lines to be drawn inaccurately.

(1) Line-thickness is improperly subtracted from the "off"
value in Line_interface::make_dashed_line. This was done,
presumably, to account for the line cap of each dash. In fact,
PostScript discounts the line cap when constructing the pattern.

(2) Dashed lines are constructed so that they begin and end
with a dash. Thus, a dashed line is built of dash + whitespace
units and a last lone dash. Period is not adjusted in
Line_interface::line for this last dash, which can lead to a
noticeable difference in its length compared to other dashes.

Correcting these flaws ensures that dashed lines end with a
dash rather than whitespace, and that terminating dashes are
not clipped. Also, the number of dashes drawn reflects the
number calculated.

http://codereview.appspot.com/320320043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto