|
| From: | Auto mailings of changes to Lily Issues |
| Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5033 LyricHyphen whiteout |
| Date: | Fri, 10 Mar 2017 23:43:34 +0000 |
author Knut Petersen address@hidden
Sat, 4 Mar 2017 18:10:19 +0000 (18:10 +0000)
committer James Lowe address@hidden
Fri, 10 Mar 2017 18:32:08 +0000 (18:32 +0000)
commit 2dc76513c4edb8e18e6170069677eb0dd9b54209
[issues:#5033] LyricHyphen whiteout
Status: Fixed
Labels: Fixed_2_19_57
Created: Mon Jan 16, 2017 01:13 PM UTC by Knut Petersen
Last Updated: Fri Mar 10, 2017 09:21 AM UTC
Owner: Knut Petersen
Attachments:
http://codereview.appspot.com/312530043 (Rietveld for attached patch)
Whiteout for LyricHyphen grobs is seldom used - obviously the hyphen must not whiteout parts of the lyric syllables. But it is a vital feature if mensuration lines are used (old music, Distler, ...)
A proper outline whiteout would be ideal, but it is not implemented ... the current code fails because you need a relatively large whiteout area for a small object. A brute force fix is to increase the number of iterations, but the result would be a pdf with a high percentage of whiteout code.
And there is the case where a long melisma produces a single hyphen event that generates a lot of hyphens that cross a number of mensuration lines. Rectangular or roundedbox whiteout will produce gaps in all mensuration lines crossed, even if there is no collision. That's not acceptable.
Attached is a patch that solves the problem. It passes a full make, and make check does not identify any problem.
WhiteoutOrig.jpg: Current code
WhiteoutImproved.jpg: Brute-force-fix - more than 90% whiteout code in the pdf
WhiteoutEvenBetter-X.jpg: Proposed behaviour as implemented in the attached patch
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------ Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition. http://sdm.link/oxford
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
| [Prev in Thread] | Current Thread | [Next in Thread] |
