|
| From: | Auto mailings of changes to Lily Issues |
| Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4938 Refactor handling of supported MIDI control changes |
| Date: | Wed, 27 Jul 2016 21:56:48 +0000 |
author Heikki Tauriainen address@hidden
Thu, 7 Jan 2016 21:02:07 +0100 (22:02 +0200)
committer James Lowe address@hidden
Wed, 27 Jul 2016 22:54:06 +0100 (22:54 +0100)
commit 528d28e079419b3a45098b42b8b2b4eb9f1b15b1
author Heikki Tauriainen address@hidden
Thu, 7 Jan 2016 21:34:56 +0100 (22:34 +0200)
committer James Lowe address@hidden
Wed, 27 Jul 2016 22:54:15 +0100 (22:54 +0100)
commit 14de2f189e75424bd0b04f4577386b4f0dde1a6e
and
author Heikki Tauriainen address@hidden
Wed, 20 Jul 2016 11:06:56 +0100 (13:06 +0300)
committer James Lowe address@hidden
Wed, 27 Jul 2016 22:54:23 +0100 (22:54 +0100)
commit 23bb09401ef1d8c5f5256b8f7a6c002365b1d88c
Many thanks as always Hiekki.
[issues:#4938] Refactor handling of supported MIDI control changes
Status: Fixed
Labels: FIxed_2_19_47
Created: Wed Jul 20, 2016 05:31 PM UTC by H T LilyPond
Last Updated: Wed Jul 27, 2016 07:36 AM UTC
Owner: H T LilyPond
This issue separates the code refactoring originally done for Issue 4745 from the enhancements implemented as part of that issue. This patch does not change any existing functionality (nor introduce any new features), its purpose is to only improve the maintainability of the current implementation by simplifying the interfaces, removing duplication of code, and cleaning up some terminology.
(Background: Issue 4745 is about the ability to annotate arbitrary MIDI CCs in LilyPond input. That issue still remains open due to still unresolved design questions raised during the review about the proper syntax and implementation for the annotations. Regardless of the eventual fate of the enhancement, I'd hate to see this code refactoring being lost, however, so that's why the current issue was created.)
http://codereview.appspot.com/309720043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
| [Prev in Thread] | Current Thread | [Next in Thread] |