[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4938 Refactor handling of supported MIDI control changes

[Auto mailings of changes to Lily Issues]

• Description has changed:

Diff:

--- old
+++ new
@@ -1,20 +1,5 @@
-Add Audio_item and Midi_item subclasses for (MIDI control, value) changes
+This issue separates the code refactoring originally done for Issue 4745 from the enhancements implemented as part of that issue.  This patch does not change any existing functionality (nor introduce any new features), its purpose is to only improve the maintainability of the current implementation by simplifying the interfaces, removing duplication of code, and cleaning up some terminology.

-
-Refactor handling of MIDI control changes
-
-Handle the MIDI control value initialization from context properties
-(Staff_performer::new_audio_staff), control value changes
-(Midi_control_function_performer::announce_function_value_change), and
-value conversion for output
-(Midi_control_function_value_change::to_string) in the new
-Midi_control_change_announcer class.
-
-All MIDI control changes are now encoded using
-{Audio,Midi}_control_change items.  This change makes the old
-{Audio,Midi}_control_function_value_change classes obsolete.
-
-
-Rename Midi_control_function_performer to Midi_control_change_performer
+(Background: Issue 4745 is about the ability to annotate arbitrary MIDI CC changes in LilyPond input.  That issue still remains open due to still unresolved design questions raised during the review about the proper syntax and implementation for the annotations.  Regardless of the eventual fate of the enhancement, I'd hate to see this code refactoring being lost, however, so that's why the current issue was created.)

 http://codereview.appspot.com/309720043

---

[issues:#4938] Refactor handling of supported MIDI control changes

Status: Started
Created: Wed Jul 20, 2016 05:31 PM UTC by H T LilyPond
Last Updated: Wed Jul 20, 2016 05:33 PM UTC
Owner: H T LilyPond

This issue separates the code refactoring originally done for Issue 4745 from the enhancements implemented as part of that issue. This patch does not change any existing functionality (nor introduce any new features), its purpose is to only improve the maintainability of the current implementation by simplifying the interfaces, removing duplication of code, and cleaning up some terminology.

(Background: Issue 4745 is about the ability to annotate arbitrary MIDI CC changes in LilyPond input. That issue still remains open due to still unresolved design questions raised during the review about the proper syntax and implementation for the annotations. Regardless of the eventual fate of the enhancement, I'd hate to see this code refactoring being lost, however, so that's why the current issue was created.)

http://codereview.appspot.com/309720043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto