[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4907 Midi_walker::do_start_note: skip ignored notes in stop_note_queue

[Auto mailings of changes to Lily Issues]

• Patch: review --> countdown
• Comment:

Patch on countdown for July 3rd.

Heikki, a Reg test was asked for in the Reitveld. Any comments?

---

[issues:#4907] Midi_walker::do_start_note: skip ignored notes in stop_note_queue

Status: Started
Created: Sun Jun 26, 2016 03:36 PM UTC by H T LilyPond
Last Updated: Mon Jun 27, 2016 05:25 PM UTC
Owner: H T LilyPond

Midi_walker::do_start_note: skip ignored notes in stop_note_queue

For each semitone pitch value, stop_note_queue is likely supposed to contain
at most one Midi_note event with its "ignore_" flag set to false, and the
comparisons between notes of equal semitone pitch to be always done between
the input note and this unique queued note that is not (yet) being ignored.

If notes which are already being ignored are not skipped in the loop, the
task of raising the "ignore_" flags for note events of equal semitone pitch
(overlapping in time) which stop before the maximum stopping time of these
notes may, due to breaking out of the loop, fail to work if there are three
or more simultaneous notes of equal semitone pitch, leading to the emission
of premature "note off" events for this pitch, as demonstrated, for example,
in http://lists.gnu.org/archive/html/bug-lilypond/2016-06/msg00042.html.

http://codereview.appspot.com/296570043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto