[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4899 Reorgani

labels: --> Fixed_2_19_45
status: Started --> Fixed
Patch: countdown -->
Comment:

Pushed to staging as
commit 5c7507115ca03b8f2f2b46e34d670ed50074b00d
Author: David Kastrup address@hidden
Date: Sat Jun 18 10:49:06 2016 +0200

Issue 4899/6: Remove {Translator,Engraver}::ack_find_base

The indirection and complication added by it does not really
help in any manner.

commit 1906a2283e10713232141886afd11dad96efcee1
Author: David Kastrup address@hidden
Date: Sat Jun 18 10:23:30 2016 +0200

Issue 4899/5: Remove Translator::method_find_base

It's basically a trivial replacement and confuses more than it helps.

commit 220f62ed61861265a5b734052806de2d1c656335
Author: David Kastrup address@hidden
Date: Sat Jun 18 10:13:10 2016 +0200

Issue 4899/4: Listeners should not be virtual

Gregorian_ligature_engraver::listen_pes_or_flexa and
Ligature_engraver::listen_pes_or_flexa were accidentally
declared virtual, but their registration already caters
for what amounts to virtual overrides in effect.

commit ffc7faa048d5c54c1c38024b80212f5f789a4361
Author: David Kastrup address@hidden
Date: Fri Jun 17 16:23:09 2016 +0200

Issue 4899/3: Revert "Issue 4885/2: Let ADD_ACKNOWLEDGER state actual classes"

This reverts commit 7c36dbb1834c7c68e4b94777241de3ea02971aca.

commit 60ceca32eb997a6ce3a974527b39a098d1ebb82e
Author: David Kastrup address@hidden
Date: Fri Jun 17 16:13:55 2016 +0200

Issue 4899/2: Revert "Issue 4885/3: Remove ack_finder/ack_find_base"

This reverts commit b9040afd1dcfbee6b45bc3d54850ff50d51c8ee9.

commit f7013d65b51f1372dc31973b78bbe04f505ea569
Author: David Kastrup address@hidden
Date: Sat Jun 18 10:20:43 2016 +0200

Issue 4899/1: Let method_finder also find listeners

This allows using inherited listeners directly like with
acknowledgers and translator methods.

[issues:#4899] Reorganize listener/acknowledger initialization

Status: Fixed
Labels: Fixed_2_19_45
Created: Sat Jun 18, 2016 11:55 AM UTC by David Kastrup
Last Updated: Thu Jun 23, 2016 07:31 AM UTC
Owner: David Kastrup

Reorganize listener/acknowledger initialization

This reverts most of the changes of issue 4885 in order to arrive at
listeners/acknowledgers that can be kept private or protected
according to the actual use cases in engravers and other translators.
It also streamlines some of the other code. Contains the following
commits in reverse order (all separately tested to compile):

Remove {Translator,Engraver}::ack_find_base

The indirection and complication added by it does not really
help in any manner.

Remove Translator::method-find_base

It's basically a trivial replacement and confuses more than it helps.

Listeners should not be virtual

Gregorian_ligature_engraver::listen_pes_or_flexa and
Ligature_engraver::listen_pes_or_flexa were accidentally
declared virtual, but their registration already caters
for what amounts to virtual overrides in effect.

Revert "Issue 4885/2: Let ADD_ACKNOWLEDGER state actual classes"

This reverts commit 7c36dbb1834c7c68e4b94777241de3ea02971aca.

Revert "Issue 4885/3: Remove ack_finder/ack_find_base"

This reverts commit b9040afd1dcfbee6b45bc3d54850ff50d51c8ee9.

Let method_finder also find listeners

This allows using inherited listeners directly like with
acknowledgers and translator methods.

http://codereview.appspot.com/301980043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4899 Reorganize listener/acknowledger initialization
Date:	Thu, 23 Jun 2016 09:16:51 +0000