[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #4903 Fold Slur_proto_engraver into Slur_engraver

[Auto mailings of changes to Lily Issues]

That looks like output of the patch program to me. patch is generally poorly suitable for applying Git patches.

Please use git apply --index on the patch instead, followed by git reset --hard after testing. The --index option makes sure that Git keeps track of any newly created files and removes them again upon resetting the working directory. Otherwise new files created by patching will just stay around in the working directory.

Shortcuts like these make it very desirable that we get the automated testing working again because then the procedures in use are well-known and, in the case of problems, can be fixed once and for all.

---

[issues:#4903] Fold Slur_proto_engraver into Slur_engraver

Status: Started
Created: Mon Jun 20, 2016 10:49 PM UTC by David Kastrup
Last Updated: Wed Jun 22, 2016 10:49 AM UTC
Owner: David Kastrup

Fold Slur_proto_engraver into Slur_engraver

A symmetrical common base class to both Slur_engraver and
Phrasing_slur_engraver seems like an unnecessary complication. Instead,
Phrasing_slur_engraver can just be derived from Slur_engraver .

Also contains commits:

Restructure slur engravers

Replaces data members specific to derived classes of Slur_proto_engraver
with virtual functions.

internal_make_grob: Remove unused `name' argument

http://codereview.appspot.com/302020043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto