[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #4877 Reve

Am 03.06.2016 um 10:36 schrieb David Kastrup:

Iff the revert went fine without any merge conflicts, the original
state should have seen years in testing already. I don't see a point
in additional manual testing then, in particular since it is highly
unlikely to expose any syptoms of this change. I recommend to just
push to staging and let the automated Patchy-staging fend off the
worst offenses.

If you had to resolve merge conflicts manually, however, review would
make more sense.

No, went well.
OK, I'll let patchy to the "review" then.

Urs

[issues:#4877]
https://sourceforge.net/p/testlilyissues/issues/4877/ Revert #4747:
(Remove (all) uses of is-absolute?

Status: Started
Created: Fri Jun 03, 2016 07:53 AM UTC by Urs Liska
Last Updated: Fri Jun 03, 2016 07:53 AM UTC
Owner: Urs Liska

Revert #4747: (Remove (all) uses of is-absolute?

This reverts

commit f30a8189adbbeefa2103e2c2e194040f66bc2291
Author: Urs Liska address@hidden address@hidden
Date: Tue Jan 19 10:52:33 2016 +0100

4747: Remove (all) uses of is-absolute?

====================

As discussion revealed the commit message is not true
and indicates a misconception (see quote below).
(car ly:input-file-line-char-column a-location) does
/not/ always return an absolute path, instead this
depends on how the file path has been passed to LilyPond.

As this commit changed the behaviour of point-and-click
in a somewhat unintentional and unmaintainable way it
is better to revert the commit. Especially as the
original behaviour was not harmful in the first place.

========================

(Original commit message:)

The check for absolute paths in in output-ps.scm
and -svg.scm is unnecessary because
(car ly:input-file-line-char-column a-location)
always returns an absolute, slashified path

Now is-absolute? is not used anymore by LilyPond itself.

http://codereview.appspot.com/295470043

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/testlilyissues/issues/4877/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[issues:#4877] Revert #4747: (Remove (all) uses of is-absolute?

Status: Started
Created: Fri Jun 03, 2016 07:53 AM UTC by Urs Liska
Last Updated: Fri Jun 03, 2016 08:36 AM UTC
Owner: Urs Liska

Revert #4747: (Remove (all) uses of is-absolute?

This reverts

commit f30a8189adbbeefa2103e2c2e194040f66bc2291
Author: Urs Liska address@hidden
Date: Tue Jan 19 10:52:33 2016 +0100

#4747: Remove (all) uses of is-absolute?

====================

As discussion revealed the commit message is not true
and indicates a misconception (see quote below).
(car ly:input-file-line-char-column a-location) does
not always return an absolute path, instead this
depends on how the file path has been passed to LilyPond.

As this commit changed the behaviour of point-and-click
in a somewhat unintentional and unmaintainable way it
is better to revert the commit. Especially as the
original behaviour was not harmful in the first place.

========================

(Original commit message:)

The check for absolute paths in in output-ps.scm
and -svg.scm is unnecessary because
(car ly:input-file-line-char-column a-location)
always returns an absolute, slashified path

Now is-absolute? is not used anymore by LilyPond itself.

http://codereview.appspot.com/295470043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #4877 Revert #4747: (Remove (all) uses of is-absolute?
Date:	Fri, 03 Jun 2016 08:53:53 +0000