[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4704 Improve beam count handling with subdivided beams

[Auto mailings of changes to Lily Issues]

• Needs: -->
  
• Patch: new --> review
• Type: -->
  
• Comment:

Passes make, make check and a full make doc.

---

[issues:#4704] Improve beam count handling with subdivided beams

Status: Started
Created: Mon Dec 21, 2015 09:44 PM UTC by Urs Liska
Last Updated: Wed Dec 23, 2015 01:37 PM UTC
Owner: Urs Liska

Improve beam count handling with subdivided beams

Subdivision beam count was improved in issue 4355, commit 8fa2d858,
but partially reverted in commit 0382ed88.

• Before 4355 there was always one beam at the subdivision
• After 4355 the beam count reflected the metric value of
  the subdivision's location
• After commit 8fa2d858 the beam count matched baseMoment

The behaviour after 4355 is correct as it gives an immediate
feedback on the metric situation, and is suggested by Gould.
The later revert was to avoid a side-effect, namely the inconsistency
with shortened beams: If the remaining length of the beam is less
than the length of the current metric group the result was
confusing.

This patch reverts the effect of the latest commit, reinstating
the behaviour of issue 4355. However, it improves handling to
remove the unwanted side-effect:
- when the remaining length of the beam is shorter than the
next group (e.g. subdivision at an 1/8 point, but only 3/32
left) the beam count matches the length of the remainder:
1/16 <= remainder < 1/8 => 2 beams
1/32 <= remainder < 1/16 => 3 beams
etc.
- but if only one stem is left after the subdivision this is not
applied. The subdivision has the regular number matching the
metric value, and the trailing single stem has beamlets according
to its actual length

http://codereview.appspot.com/276560043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto