lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 4564 in lilypond: make Grob an abstract class


From: lilypond
Subject: Re: [Lilypond-auto] Issue 4564 in lilypond: make Grob an abstract class
Date: Tue, 18 Aug 2015 16:54:43 +0000


Comment #6 on issue 4564 by address@hidden: make Grob an abstract class
https://code.google.com/p/lilypond/issues/detail?id=4564

In as far as the patch tries to create a type relation between derived classes that is not intended to even reflect any sensible object relation, I do object to this patch in itself.

I cannot claim an absolute ban over such pointer abuse since the classes defined in lily/include/small-smobs.hh similarly abuse a this-pointer and member functions for carrying information unrelated to actually existing objects. However, in that case this is a trade-off allowing for easy conversion between SCM objects with and without extra allocated memory and thus is connected to actual matters of efficiency.

I don't see any comparable tradeoff here that would serve to justify the abuse of the type lattice.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]