Re: [Lilypond-auto] Issue 4539 in lilypond: Set the sequence name in MIDI using title information from \header block

[lilypond]

Comment #11 on issue 4539 by address@hidden: Set the sequence name  
in MIDI using title information from \header block
https://code.google.com/p/lilypond/issues/detail?id=4539

On 2015/08/07 11:15:46, ht wrote:
> On 2015/08/07 10:49:56, J_lowe wrote:
> > Oh one thing to add, I am seeing a lot of this in the reg test:
> >
> > --snip--
> >
> >
> > input/regression/midi/staff-map-instrument.midi    
> >
> > @@ -1,4 +1,4 @@
> > -track 0  ev (0, (255, 3, 'control track'))
> > +track 0  ev (0, (255, 3, ''))
> >    ev (0, (255, 1, 'creator: '))
> >    ev (0, (255, 88, '\x04\x02\x12\x08'))
> >    ev (0, (255, 81, '\x0fB@'))
> >
> > --snip--
> >
> > I assume that is expected?

> Yes, such differences are exactly what's expected as a result of this  
> change: in
> place of the string "control track", there MIDI event should contain a  
> string
> from the title field of a \header block in the input file (or an empty  
> string if
> there's no \header block which could be associated with a \midi { } block  
> in a
> LilyPond input file).

> I guess I need to still update the patch with the changes to the  
> regression test
> results – I'll try to do this today.

Hmm... Reading through the "Regression tests" section of the Contributor's
guide, I'm starting to get the impression that the expected results of
regression tests are not actually part of the source tree, so they can't be
changed simply in a patchset.  Is this correct?

What I could do, however, is to add the input file (in my first comment to  
this
Rietveld issue) as a new regression test to the codebase.


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings