lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] Issue 4491 in lilypond: replace BUILD_DIR with LILYPOND_


From: lilypond
Subject: [Lilypond-auto] Issue 4491 in lilypond: replace BUILD_DIR with LILYPOND_BUILD_DIR for consistency
Date: Fri, 10 Jul 2015 16:29:55 +0000

Status: Accepted
Owner: ----
Labels: Type-Scripts

New issue 4491 by address@hidden: replace BUILD_DIR with LILYPOND_BUILD_DIR for consistency
https://code.google.com/p/lilypond/issues/detail?id=4491

Reported by Paul:

###

Keith noted that:
"Looking at the first few lines of update-with-convert-ly, it looks
like it expects you to have defined the build directory as BUILD_DIR
where most other scripts expect LILYPOND_BUILD_DIR.”

A workaround is to run:
export BUILD_DIR=$LILYPOND_BUILD_DIR

Two possible ways to fix:
- add BUILD_DIR as an environmental variable in LilyDev
- edit the script to use LILYPOND_BUILD_DIR

####

Federico: I'm in favour of the second option because of consistency.

$ git grep -w BUILD_DIR
Documentation/contributor/programming-work.itexi:BUILD_DIR=../build-lilypond/ scripts/auxiliar/update-with-convert-ly.sh
scripts/auxiliar/update-with-convert-ly.sh:if [ -z $BUILD_DIR ]; then
scripts/auxiliar/update-with-convert-ly.sh: BUILD_DIR=.
scripts/auxiliar/update-with-convert-ly.sh:cd $BUILD_DIR
scripts/auxiliar/update-with-convert-ly.sh: | xargs $BUILD_DIR/out/bin/convert-ly -e -d "$@" scripts/auxiliar/update-with-convert-ly.sh: | xargs $BUILD_DIR/out/bin/convert-ly -e -d "$@"



--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

reply via email to

[Prev in Thread] Current Thread [Next in Thread]