Re: [Lilypond-auto] Issue 4357 in lilypond: Patch: Redesign listeners using templates

[lilypond]

Updates:
        Labels: -Patch-needs_work Patch-new

Comment #18 on issue 4357 by address@hidden: Patch: Redesign listeners using  
templates
https://code.google.com/p/lilypond/issues/detail?id=4357#c18

Issue 4357: Next rebase of upload.  Should actually be quite the same
as the version before last rebase since issue 4373 now is in the race
as a substitute for the ill-fated and reverted issue 4360 and can get
reviewed in parallel with this one as there are no merge/rebase
conflicts between the two.


Remove Scheme listeners as they are just callbacks now.


Reimplement Listener around generic SCM callback and instance


Run preparatory script replacing listener macros

This script is

for i in $(git grep -l 'IMPLEMENT_LISTENER (')
do
    sed -i '/IMPLEMENT_LISTENER ([^)]*$/{N;s/\n\s*/ /}' $i
    sedscript=$(git grep -h 'IMPLEMENT_LISTENER (' $i|
		       sed 's|^.*IMPLEMENT_LISTENER (\([^,]*\), \([^)]*\)).*$| 
s/GET_LISTENER (\\([_a-z]\\+->\\)\\?\2)/\\1GET_LISTENER (\1, \2)/|')
    sed -i "$sedscript" $i
done
sed -i '/IMPLEMENT_LISTENER (/d' $(git grep -l 'IMPLEMENT_LISTENER (')
sed -i 's/DECLARE_LISTENER (\([^)]*\));\?/void \1 (SCM);/' $(git grep  
-l 'DECLARE_LISTENER (')

Make dispatchers callable for dispatching


Move self_scm_ into non-templated Smob_core base class.

http://codereview.appspot.com/232190043

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings