[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Lilypond-auto] Issue 4270 in lilypond: Articulate.ly: Fix bug introduce
From: |
lilypond |
Subject: |
[Lilypond-auto] Issue 4270 in lilypond: Articulate.ly: Fix bug introduced in commit 88e1d22 (previously issue 4247) |
Date: |
Fri, 23 Jan 2015 11:46:33 +0000 |
Status: Accepted
Owner: address@hidden
Labels: Type-Defect Patch-new
New issue 4270 by address@hidden: Articulate.ly: Fix bug introduced in
commit 88e1d22 (previously issue 4247)
https://code.google.com/p/lilypond/issues/detail?id=4270
>>>>> "pkx166h" == pkx166h <address@hidden> writes:
pkx166h> On 2015/01/20 22:08:16, Peter Chubb wrote:
>> articulate.ly: Fix \trillSpan problem
pkx166h> Peter, I can see 4 patches uploaded here but it looks like
pkx166h> from the time stamps that this was some git-cl error or
pkx166h> something similar?
There was supposed to be only one.
git format-patch origin
yields:
From 47e8cd08748e2d1d00a725148511f8290eed8f8e Mon Sep 17 00:00:00 2001
From: Peter Chubb <address@hidden>
Date: Wed, 21 Jan 2015 08:18:19 +1100
Subject: [PATCH] Fix trill-span errors
The last change introduced a bug: ac:twiddletime returns a moment, and it
was changed to return a duration. This causes a lilypond error when
using trillspan and articulate.
Articulate.ly: Fix mordent and prall timing for short notes
When a prall or mordent was on a note shorter than a semiquaver,
the calculation of timing for the main note after stealing the time
for the ornament used to generate a negative duration.
Instead of a subtracting ornament time from the main note, generate the
ornament using a fixed timing, tack it on the beginning, and then
compress the resulting music to be the same length as the original.
Issue firsty reported by Patrick or Cynthia Karl.
http://codereview.appspot.com/190530043
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
- [Lilypond-auto] Issue 4270 in lilypond: Articulate.ly: Fix bug introduced in commit 88e1d22 (previously issue 4247),
lilypond <=