Re: [Lilypond-auto] Issue 4196 in lilypond: Patch: Add \numbered-time-signature markup command

[lilypond]

Comment #4 on issue 4196 by address@hidden: Patch: Add  
\numbered-time-signature markup command
https://code.google.com/p/lilypond/issues/detail?id=4196

I think I should post a review of all my C++-to-scheme work to give you  
context.  It won't be today, though, so I'll attempt to answer your  
question briefly.

> How about only making a \time-signature markup command?  The style can  
> just be taken from the "style" property.

That would amount to (1) use style as a key to look up a markup procedure  
and (2) call the procedure.  This is what the time-signature print callback  
does in my branch.  What I have posted here is the inner procedure that is  
called directly for the "numbered" style, wrapped in a very simple lambda  
for the "single-digit" style, or called from a slightly more complicated  
function for the "C" style when no glyph is found.

As I mentioned in the review, if you don't want to see  
\numbered-time-signature as a documented markup command, I'll be happy to  
convert it back to just a function that builds markup.

A generic \time-signature could be implemented if it were useful, but I  
don't think it's actually that useful, and the interface required for  
compound time signatures is an unnecessary complication for styles other  
than numbered.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings