[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 4107 in lilypond: Patch: Use START/STOP for *r
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 4107 in lilypond: Patch: Use START/STOP for *recurse_over_translators instead of the counterintuitive DOWN/UP |
Date: |
Wed, 01 Oct 2014 17:42:44 +0000 |
Updates:
Status: Fixed
Labels: -Fixed_2_19_15 Fixed_2_19_16
Comment #8 on issue 4107 by address@hidden: Patch: Use START/STOP for
*recurse_over_translators instead of the counterintuitive DOWN/UP
https://code.google.com/p/lilypond/issues/detail?id=4107
After looking at a number of usages and other occurences, it has become
clear that "START" and "STOP" were the wrong idea here:
UP means to start the recursive call of translators in the lower contexts
and move UP, DOWN means to start the calls at the top and move DOWN in
recursion.
For initialization, you usually want to go DOWN. For cleanup, you want to
go UP. That much was in a sort-of correspondence with START/STOP. But
there are other uses where this change just does not make sense.
I'm reverting this. Sigh.
Reverted as
commit 7bf722b8cd022e2fadedf774ddee13d118179044
Author: David Kastrup <address@hidden>
Date: Wed Oct 1 19:40:43 2014 +0200
Revert "Issue 4107/1: Use START/STOP for *recurse_over_translators
instead o
This reverts commit 113223f5d488baf62b0e1a7bf4c2cfee037f4e0e.
commit ff22b3332b1089d38226f15a72040d8cbc202c12
Author: David Kastrup <address@hidden>
Date: Wed Oct 1 19:40:34 2014 +0200
Revert "Issue4107/2: Score_performer::prepare:
precomputed_recurse_over_tran
This reverts commit 0e1e8169813d68179939d2361936cb4e80f7c394.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Lilypond-auto] Issue 4107 in lilypond: Patch: Use START/STOP for *recurse_over_translators instead of the counterintuitive DOWN/UP,
lilypond <=