Re: [Lilypond-auto] Issue 4096 in lilypond: \addlyrics always creates its own Voice context

[lilypond]

Updates:
        Status: Fixed
        Labels: -Patch-push Fixed_2_19_14

Comment #12 on issue 4096 by address@hidden: \addlyrics always creates its own  
Voice context
https://code.google.com/p/lilypond/issues/detail?id=4096

Pushed to staging as
*   commit 5b2267a97cfb085c4492e2954c0b9eec36fc11f8
|\  Merge: 92f1830 5937be9
| | Author: David Kastrup <address@hidden>
| | Date:   Sun Sep 14 07:46:29 2014 +0200
| |
| |     Merge branch 'issue4096' into HEAD
| |
| * commit 5937be99ecf9872f5dad2bc689099179400b70ff
| | Author: David Kastrup <address@hidden>
| | Date:   Mon Sep 8 15:32:47 2014 +0200
| |
| |     Add regtest for issue 4096, \addlyrics using existing contexts
| |
| * commit 21af7576f26f9b79bc7a4dfcfa041b3b5ced47e7
| | Author: David Kastrup <address@hidden>
| | Date:   Mon Sep 8 17:24:37 2014 +0200
| |
| |     Convert \new Staff ... \addlyrics into \new Staff \new Voice ...  
\addlyrics
| |
| * commit eda1a9e297d93e074d10e86dfdeae1226f86b4cd
| | Author: David Kastrup <address@hidden>
| | Date:   Mon Sep 8 11:28:14 2014 +0200
| |
| |     Give \addlyrics the power of christening the associated context
| |
| |     With
| |
| |     \new Voice \with { \stemDown } { c1 } \addlyrics { Oh }
| |
| |     as opposed to
| |
| |     \new Voice = "upper" \with { \stemDown } { c1 } \addlyrics { Oh }
| |
| |     \addlyrics created its own context (consequently not using  
\stemDown)
| |     since it had no context name for the Lyrics context to attach to.   
In
| |     this case (namely being preceded by an unnamed new Voice context),  
it
| |     will now give a name to the context itself.
| |
| * commit 32f47bdec7c2008ebff80d68463d022946db5df2
| | Author: David Kastrup <address@hidden>
| | Date:   Mon Sep 8 11:15:19 2014 +0200
| |
| |     Fix bugs preventing \addlyrics from finding an existing context to  
attach to
| |
| * commit 4015468c822eae4e9421ca6640b0ecf6e75e8d7d
| | Author: David Kastrup <address@hidden>
| | Date:   Mon Sep 8 11:01:56 2014 +0200
| |
| |     Refactor grammar to give \addlyrics a good target to attach to
| |
| |     So far,
| |
| |         \new Staff \new Voice { c1 } \addlyrics { Oh } \addlyrics { Ah }
| |
| |     was factored as
| |
| |         \new Staff \new Voice { { c1 } \addlyrics { Oh } \addlyrics {  
Ah } }
| |
| |     which resulted in something like
| |
| |        \new Staff \new Voice
| |          << \context Voice = "uniqueContext0" { c1 }
| |             \new Lyrics \lyricsto "uniqueContext0" { Oh }
| |             \new Lyrics \lyricsto "uniqueContext0" { Ah }
| |          >>
| |
| |     This made it impossible to work with the likes of
| |
| |       \new Staff \new Voice \with { \stemUp } { c1 } \addlyrics ...
| |
| |     since the voice the lyrics attached to was always a new voice.
| |     Fixing the grouping in the grammar is a first required step for  
getting
| |     this under control.
| |
| * commit 5c2efacf079a69d97da4466dd1179530759bc114
| | Author: David Kastrup <address@hidden>
| | Date:   Mon Aug 4 09:55:17 2014 +0200
| |
| |     Refactor grammar, folding re_rhythmed_music into composite_music
| |
| * commit b29bd8c074843e26aba40cebc5e226bea69d045a
|/  Author: David Kastrup <address@hidden>
|   Date:   Mon Aug 4 09:55:17 2014 +0200
|
|       Refactor grammar, folding complex_music into composite_music


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings