lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 3978 in lilypond: Patch: cleanup alignments of


From: lilypond
Subject: Re: [Lilypond-auto] Issue 3978 in lilypond: Patch: cleanup alignments of various grobs (follow-up to 3254 and 3962)
Date: Sat, 05 Jul 2014 21:15:14 +0000

Updates:
        Status: Fixed
        Labels: -Patch-push Fixed_2_19_10

Comment #15 on issue 3978 by address@hidden: Patch: cleanup alignments of various grobs (follow-up to 3254 and 3962)
http://code.google.com/p/lilypond/issues/detail?id=3978

Pushed as merge commit:

*   commit 0bc7f77ff63d9aa044f7d75f9cce255ed2afc0f2
|\  Merge: f4b89d7 d6604b0
| | Author: Janek Warchoł <address@hidden>
| | Date:   Sat Jul 5 23:11:40 2014 +0200
| |
| |     Issue 3978: Merge alignment cleanup
| |
| | Make DynamicTexts, TextScripts and many other grobs use aligned_on_parent, | | which makes their behaviour consitent, predictable and thus more user-friendly.
| |
| * commit d6604b0444dfea8c1ad571273c78222ad17ccd2d
| | Author: Janek Warchoł <address@hidden>
| | Date:   Fri Jul 4 22:42:08 2014 +0200
| |
| |     define-grobs.scm: reorder properties alphabetically
| |
| * commit 6f3f8f0fceed3b318c2572337e7dca83e4a11f6c
| | Author: Janek Warchoł <address@hidden>
| | Date:   Mon Jun 23 23:30:49 2014 +0200
| |
| |     TextScript, CombineTextScript: use aligned_on_parent
| |
| |     I think this makes more sense than just using "self-alignment".
| |     It makes these grobs consistent with Lyrics and Dynamics, and
| |     allows users to override their alignment more predictably.
| |
| |     Expected changes in output: TextScripts and CombineTextScripts
| | will be aligned slightly different when the user sets self-alignment-X | | explicitly (parent notehead will be included in alignment, as in Lyrics).
| |     Default placement should remain the same.
| |
| | I'm also changing one regtest, just to make sure that despite slightly
| |     changed alignment the markups will stick out far enough to the left.
| |
| * commit 1d765020f867995879c761f2c9351c9dc74f1df8
| | Author: Janek Warchoł <address@hidden>
| | Date:   Mon Jun 23 23:04:26 2014 +0200
| |
| |     Replace XY-offset closures with aligned_on_parent where possible
| |
| |     It doesn't make sense to specify placement using multiple added
| |     callbacks or closures when we can use aligned_on_parent. What's
| |     more, aligned_on_parent should expose more consistent interface
| |     for the users - affected grobs should now behave similarly to
| |     LyricTexts and DynamicTexts. For example, this
| |
| |     \relative c'' \context Voice {
| |       \compressFullBarRests
| |       \override MultiMeasureRestNumber.self-alignment-X = #RIGHT
| |       R1*100
| |     }
| |
| |     will result in right edge of the MultiMeasureRestNumber being
| |     aligned on the right edge of the MultiMeasureRest.
| |
| |     Affected grobs:
| |     - AccidentalSuggestion
| |     - ClefModifier
| |     - DoublePercentRepeatCounter
| |     - Fingering
| |     - GridLine
| |     - MultiMeasureRestNumber
| |     - MultiMeasureRestText
| |     - PercentRepeatCounter
| |     - StemTremolo
| |
| |     Expected changes in output: none.
| |
| * commit 09412c25cce3fdffce7cefe491cb3849ece0ae3e
|/  Author: Janek Warchoł <address@hidden>
|   Date:   Sat Mar 30 00:11:28 2013 +0100
|
|       Clean up DynamicText horizontal alignment.
|
| Until now, DynamicText alignment was messy, as there were 3 different
|       callbacks involved - some of them interacting in a confusing way:
|        - in define-grobs.scm, X-offset property was initialized to
|          ly:self-alignment-interface::x-aligned-on-self,
|        - Dynamic_engraver called set_center_parent on every DynamicText
| attached to a note, so that half a NoteHead width was always added
|          to its X-offset (producing confusing results for example when
|          user requested dynamics to be left-aligned),
|        - DynamicTexts living in a Dynamics context used a completely
|          different offset callback, which aligned them on NoteColumns.
|
|       Since aligned_on_parent is now able to correctly align grobs
|       with PaperColumn parents (issue 3254), we can use it for all
|       DynamicTexts and have a single interface for the job.
|
|       Expected changes in output: DynamicTexts in Dynamics context
|       aligned to suspended noteheads may be placed up to 1/4 NoteHead
|       width further to the right.  This shouldn't be a problem.
|


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

reply via email to

[Prev in Thread] Current Thread [Next in Thread]