Re: [Lilypond-auto] Issue 3778 in lilypond: SVG backend: tempo marking collides with stem

[lilypond]

Comment #24 on issue 3778 by address@hidden: SVG backend: tempo marking  
collides with stem
http://code.google.com/p/lilypond/issues/detail?id=3778

In stencil-integral.cc, the routine stencil_traverser looks fishy in  
several places.  While I don't see how this could affect different backends  
differently, it still seems worth fixing.

To wit:
  else if (expr == ly_string2scm (""))
    return vector<Transform_matrix_and_expression> ();
The comparison will not in general be useful since ly_string2scm ("") is  
not guaranteed to be eq? to any other instance of "".

  else
    {
      vector<Transform_matrix_and_expression> out;
      out.push_back (Transform_matrix_and_expression (trans, expr));
      return out;
    }
  warning ("Stencil expression not supported by the veritcal skylines.");
  return vector<Transform_matrix_and_expression> ();

The warning cannot ever be reached.  In stencil_dispatcher we have
  else
    {
#if 0
      warning ("Stencil expression not supported by the veritcal  
skylines.");
#endif
      /*
        We don't issue a warning here, as we assume that  
stencil-expression.cc
        is doing stencil-checking correctly.
      */
    }
Which seems absurd: if the warning is not supposed to be triggered, one can  
do a programming_error instead, but outcommenting it seems like "let's hide  
this problem away" behavior.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings