lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 3663 in lilypond: Crash with \repeat ... \alte


From: lilypond
Subject: Re: [Lilypond-auto] Issue 3663 in lilypond: Crash with \repeat ... \alternative and \remove "Bar_engraver"
Date: Tue, 19 Nov 2013 12:09:44 +0000


Comment #5 on issue 3663 by address@hidden: Crash with \repeat ... \alternative and \remove "Bar_engraver"
http://code.google.com/p/lilypond/issues/detail?id=3663

"the continued volta bracket
does not start on a bar line at the beginning of a line,
so the scheme code threw an error on these occasions,
so I added the test for left/right-bar-broken."

A continued volta bracket may or may not start on a bar line. That does not seem to make a lot of sense. In addition, the patch I committed followed the original logic, and it <em>still</em> needed to cater extra for a missing bar line grob by substituting the original grob as replacement.

At any rate, the question to answer is: is replacing this grob the right thing to do? Should we rather be passing layout and bar line grob separately to the respective functions? I don't understand the design, and I have no idea what the code is trying to do, given what input, and producing what output.

There are no comments sufficient for me to figure this out.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]