Re: [Lilypond-auto] Issue 3581 in lilypond: Patch: Add support for setting MIDI pan position, and reverb and chorus levels

[lilypond]

Comment #31 on issue 3581 by address@hidden: Patch: Add support for setting  
MIDI pan position, and reverb and chorus levels
http://code.google.com/p/lilypond/issues/detail?id=3581

Ok, here I have a problem:
commit d0e3e48668636f4c66ecdc11f8e297d9d653364a
Author: Heikki Tauriainen <address@hidden>
Date:   Sat Oct 19 10:20:10 2013 +0300

    Remove definition of the "instrumentName" property from Score_performer

    This setting has no effect; furthermore, according to the discussion on
    issue 3581 and the related patch review comments, no default settings  
for
    MIDI controls should ever be enforced if they are not set explicitly.


"This setting has no effect" is simply wrong.  instrumentName is consulted  
as a fallback for midiInstrumentName in Dynamic_performer::equalize_volume  
before reverting to the hardcoded fallback "piano".

Now "piano" is not an actually existing Midi instrument and has no  
equalization entry.  As contrast to the now removed "bright acoustic".

Now the old code is nothing to write home about.  Nevertheless this now  
leads to changed behavior and one needs to check that the fallbacks that  
now see the life of day made sense.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings