[Lilypond-auto] Issue 3500 in lilypond: Patchy apparently fails to clean up after tests, leading to interdependencies and failures

[lilypond]

Status: Accepted
Owner: ----
Labels: Type-Scripts

New issue 3500 by address@hidden: Patchy apparently fails to clean up after  
tests, leading to interdependencies and failures
http://code.google.com/p/lilypond/issues/detail?id=3500

I see the following:
CPU_COUNT=3 ../lilypond-extra/patches/test-patches.py
issues [3487, 3465, 3385, 3363]
Trying issue 3487
Found url: http://codereview.appspot.com/12988043
Found patch: 3487,/usr/local/tmp/lilypond/issue12988043_1.diff,
Trying issue 3465
Found url: http://codereview.appspot.com/12844043
Found patch: 3465,/usr/local/tmp/lilypond/issue12844043_7001.diff,
Trying issue 3385
Found url: http://codereview.appspot.com/12921043
Found patch: 3385,/usr/local/tmp/lilypond/issue12921043_8001.diff,
Trying issue 3363
Found url: http://codereview.appspot.com/12951044
Found patch: 3363,/usr/local/tmp/lilypond/issue12951044_5001.diff,
Fetching, cloning, compiling master.
(UTC) Begin LilyPond compile, previous commit at 	 
7758ba18b05420427c30b8ffbc02dc201ab7b1ea
Merged master, now at:  7758ba18b05420427c30b8ffbc02dc201ab7b1ea
        Success:                ./autogen.sh --noconfigure
        Success:                /tmp/lilypond-autobuild/configure 
--disable-optimising
        Success:                nice make clean
        Success:                nice make -j3
        Success:                nice make test-baseline -j3
Issue 3487:
Issue 3487: Testing patch issue12988043_1_diff
        Success:                git apply --index 
/usr/local/tmp/lilypond/issue12988043_1.diff
        Success:                ./autogen.sh --noconfigure
        Success:                /tmp/lilypond-autobuild/configure 
--disable-optimising
        Success:                nice make clean
        Success:                nice make -j3
        Success:                nice make check -j3
Issue 3487: Cleaning up
        Success:                nice make test-clean
        Success:                nice make clean
Issue 3487: Done.
Issue 3465:
Issue 3465: Testing patch issue12844043_7001_diff
        Success:                git apply --index 
/usr/local/tmp/lilypond/issue12844043_7001.diff
        Success:                ./autogen.sh --noconfigure
        Success:                /tmp/lilypond-autobuild/configure 
--disable-optimising
        Success:                nice make clean
        Success:                nice make -j3
        Success:                nice make check -j3
Issue 3465: Cleaning up
        Success:                nice make test-clean
        Success:                nice make clean
Issue 3465: Done.
Issue 3385:
Issue 3385: Testing patch issue12921043_8001_diff
*** FAILED BUILD ***
        git apply --index /usr/local/tmp/lilypond/issue12921043_8001.diff
        Previous good commit:   61275ff8fa4fa01422b4dd6dfc0f6372c7d9cd5e
        Current broken commit:  7758ba18b05420427c30b8ffbc02dc201ab7b1ea
Error: issue 3385: Problem encountered
Traceback (most recent call last):
  File "/usr/local/tmp/lilypond-extra/patches/projecthosting_patches.py",  
line 277, in do_check
    results_url = autoCompile.test_issue (issue_id, patch)
   
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py",  
line 271, in test_issue
    self.patch (patch, issue_id)
   
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py",  
line 304, in patch
    issue_id)
   
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py",  
line 266, in runner
    raise FailedCommand ("Failed runner: %s\nSee the log file %s" %  
(command, this_logfilename))
FailedCommand: Failed runner: git apply --index  
/usr/local/tmp/lilypond/issue12921043_8001.diff
See the log file  
log-3385-git-apply---index--usr-local-tmp-lilypond-issue12921043_8001.diff.txt

Issue 3385: Cleaning up
        Success:                nice make test-clean
        Success:                nice make clean
Issue 3385: Done.
Issue 3363:
Issue 3363: Testing patch issue12951044_5001_diff
*** FAILED BUILD ***
        git apply --index /usr/local/tmp/lilypond/issue12951044_5001.diff
        Previous good commit:   61275ff8fa4fa01422b4dd6dfc0f6372c7d9cd5e
        Current broken commit:  7758ba18b05420427c30b8ffbc02dc201ab7b1ea
Error: issue 3363: Problem encountered
Traceback (most recent call last):
  File "/usr/local/tmp/lilypond-extra/patches/projecthosting_patches.py",  
line 277, in do_check
    results_url = autoCompile.test_issue (issue_id, patch)
   
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py",  
line 271, in test_issue
    self.patch (patch, issue_id)
   
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py",  
line 304, in patch
    issue_id)
   
File "/usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py",  
line 266, in runner
    raise FailedCommand ("Failed runner: %s\nSee the log file %s" %  
(command, this_logfilename))
FailedCommand: Failed runner: git apply --index  
/usr/local/tmp/lilypond/issue12951044_5001.diff
See the log file  
log-3363-git-apply---index--usr-local-tmp-lilypond-issue12951044_5001.diff.txt

Issue 3363: Cleaning up
        Success:                nice make test-clean
        Success:                nice make clean
Issue 3363: Done.

Now it is nice that Patchy uses "git apply --index" since that means it is  
possible to do "git reset --hard" in order to arrive at the state before  
applying a patch.  However, it never seems to actually do the "git reset  
--hard".  In addition, "make clean" should be done before "git reset  
--hard" in order to remove the created files with a Makefile corresponding  
to the tested patch.

Actually, it would be nice to have an option for telling Patchy "don't  
clean up after failure but abort" since the saved logs are not always  
sufficient for figuring out what went wrong.  But that's a different  
problem.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings