Re: [Lilypond-auto] Issue 3473 in lilypond: Patch: Rewrite STEPMAKE_GET_VERSION.

[lilypond]

Updates:
        Labels: -Patch-countdown Patch-needs_work

Comment #22 on issue 3473 by address@hidden: Patch: Rewrite  
STEPMAKE_GET_VERSION.
http://code.google.com/p/lilypond/issues/detail?id=3473

My own reluctance is twofold: first, just not to break anything on any  
platform. The perfect example is right here in the first patch: a benign  
modification, it would seem, that passed the build test on the first  
person's machine, but then it failed on mine. It's clear that we are not  
testing this stuff on enough systems.

Second, with the patch, configure's running time is increased by roughly  
7%. I'm not sure if it's because we're now calling each program twice to  
get the --version output, or because of the use of a shell function instead  
of inlining all code. Nevertheless, IMHO this does not accomplish an  
improvement.

Finally, I am very surprised by the reluctance to simply opt for a more  
step by step approach. I went the extra length in providing two alternative  
baby-step patches. Werner, feel free to just take ownership of any of them  
and resubmit as your own (or provide your own). But my own impression is  
that this still needs work.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings