lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 3330 in lilypond: bracketify-stencil moves gro


From: lilypond
Subject: Re: [Lilypond-auto] Issue 3330 in lilypond: bracketify-stencil moves grob's refpoint
Date: Mon, 13 May 2013 13:56:08 +0000

Updates:
        Labels: -Patch-review Patch-needs_work

Comment #53 on issue 3330 by address@hidden: bracketify-stencil moves grob's refpoint
http://code.google.com/p/lilypond/issues/detail?id=3330

markup-word-wrap actually goes crazy at its bottom, not wrapping anything. Which is a showstopper.

page-headers-and-footers is getting less vertical spacing, but the rather crazy input appears to rely on empty material from false conditions of \on-the-fly ... to actually take out a line of spacing with an appallingly small value of baseline-skip:

  oddHeaderMarkup = \markup  {
    \override #'(baseline-skip . 1)
    \center-column {
      \box \fill-line { \teeny " " " " }
      \on-the-fly #first-page "first-page-header-text"
      \on-the-fly #not-first-page \fromproperty #'page:page-number-string
      \on-the-fly #(on-page 2) "page-2-header-text"
      \on-the-fly #last-page "last-page-header-text"
    }
  }

I'm pretty convinced that the behavior that this input appears to expect is a lot less sane than what it gets: no space reserved for empty fields. So it would likely make more sense to amend the regtest than anything else.

pdfmark-metadata is changed, but in this case clearly the result is what the test originally intended. The behavior in current master, in contrast, clobbers several parts. It is my guess that this once worked as intended and then broke unnoticed at once point of time since regtest grob metrics did not see the change to the worse.

Quite a few tests crank out just "Lieblich, etwas geschwind" as a slightly shifted change.

There are several drawing-order related difference (like starting-* and stencil-color-rotation) that are somewhat suspicious since ly:stack-stencils (with its different drawing order) has been decoupled from ly:stencil-combine-at-edge. Warrants double-checking.

It is a bit of a nuisance that all footnote tests turn up because of the saner metrics of the footnote separator line. Ok, that's it for now.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]