lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 3330 in lilypond: bracketify-stencil moves gro


From: lilypond
Subject: Re: [Lilypond-auto] Issue 3330 in lilypond: bracketify-stencil moves grob's refpoint
Date: Sun, 28 Apr 2013 13:14:59 +0000

Updates:
        Labels: -Patch-needs_work Patch-new

Comment #11 on issue 3330 by address@hidden: bracketify-stencil moves grob's refpoint
http://code.google.com/p/lilypond/issues/detail?id=3330#c11

Issue 3330: redo much of the stencil stacking/spacing/empty-check

This contains a number of commits:


Keep half-empty buildings out of skylines


Let \hspace and \vspace use Y-empty and X-empty spacing, respectively


simplify stack-stencils


Let stack-lines not use padding before X-empty stencils.


Let stack-stencil-line not use spacing around Y-empty stencils


Let Stencil::align_to check axis-specific emptiness before punting


Let Stencil::add_at_edge skip offsets for half-empty stencils

Actually, in-axis direction half-empty stencils are omitted, while
out-of-axis half-empty stencils (usually vspace/hspace) are added
without padding.

Let Box::translate ignore empty axes


Give ly:stencil-empty? an optional axis argument


Create Stencil::is_empty (Axis)


Let Stencil::is_empty use Box::is_empty

This is a change in semantics as an axis interval of '(1 . -1) is considered
empty as an interval, while it is not sufficient for making a box axis
empty.

Make Box::is_empty more selective and create an axis-specific variant

Boxes are not really "empty" just because they show negative
advancement on some axis.  A box is empty if its original dimensions
of (+inf . -inf) are still unchanged for both axes.  And boxes can
make an impact in one axis but not another, so is_empty can take an
axis as argument now.

Use (+inf . -inf) consistently for empty stencil intervals

http://codereview.appspot.com/8869044

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]