lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] Issue 3275 in lilypond: Patch: remove more evil code


From: lilypond
Subject: [Lilypond-auto] Issue 3275 in lilypond: Patch: remove more evil code
Date: Fri, 29 Mar 2013 16:27:31 +0000

Status: Started
Owner: ----
Labels: Type-Enhancement Patch-new

New issue 3275 by address@hidden: Patch: remove more evil code
http://code.google.com/p/lilypond/issues/detail?id=3275

remove more evil code


remove evil code


finger-engraver ok this time - move some stuff to later stage


changes in new-fingering-engraver - works


2245 for dynamics (notecolumn as parent)


get rid of dynamic closure - not needed anymore


draft: fix dynamics


allow different alignment for me and parent - tidy version


If a grob's parent is a PaperColumn, align using NoteColumn extent.

This makes unassociated lyrics behave consistently with associated
lyrics.

Until now, unassociated lyrics (lyrics without an associatedVoice)
were all left-aligned (more precisely: their X-offset was 0).
Changing self-alignment-X didn't have any effect on them.
This was because X-parent of an unassociated LyricText is a
PaperColumn, and aligned_on_parent didn't know how to handle that.

This patch tells aligned_on_parent to use the extent of respective
NoteColumn as the parent extent needed for grob alignment.
Additionally to fixing unassociated lyrics behaviour, this should
allow correctly aligning_on_parent other grobs, such as DynamicTexts.

Expected changes in regtests: all lyrics should now be centered by
default. This affects 11 regtests.

Rewrite self_alignment_interface, introduce align_grob (issue 3239)

Reduce code duplication: replace aligned_on_parent, aligned_on_self
and centered_on_object with align_grob.

All changes are internal and not visible to the user - offset
callbacks should continue to work exactly the same as before.
There should be no changes in Lily behaviour from this commit.

More changes to alignment interface are expected to follow:
 - allowing different alignment for grob and its parent,
 - cleanup of grob definitions (define-grobs.scm etc.),
 - aligning on grobs other than respective parent,
 - ...

http://codereview.appspot.com/8147045

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]