lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 2990 in lilypond: \RemoveEmptyStaves in StaffG


From: lilypond
Subject: Re: [Lilypond-auto] Issue 2990 in lilypond: \RemoveEmptyStaves in StaffGroup context crashes
Date: Sat, 22 Dec 2012 10:37:04 +0000

Updates:
        Labels: -Patch-countdown Patch-needs_work

Comment #14 on issue 2990 by address@hidden: \RemoveEmptyStaves in StaffGroup context crashes
http://code.google.com/p/lilypond/issues/detail?id=2990

It turns out that a check for this is already in place, see
Axis_group_engraver::process_acknowledged

It would just turn out that some callbacks from the skyline code trigger at such an early time that the validity checks (which happen to be done in an efficient way) are being run too late and/or the data structures they are based on are not kept in working order.

So I would suggest that we fix the breakage of the assumptions of the original checks (which worked before the pure/skyline stuff got into play) instead of tacking expensive handwaving checks somewhere else and leaving the broken hull of once working well-designed code rotting around in place.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]