lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] Issue 2689 in lilypond: Patch: Avoid duplication between


From: lilypond
Subject: [Lilypond-auto] Issue 2689 in lilypond: Patch: Avoid duplication between slur and phrasing slur engravers.
Date: Sat, 21 Jul 2012 12:44:26 +0000

Status: New
Owner: ----
Labels: Type-Enhancement Patch-new

New issue 2689 by address@hidden: Patch: Avoid duplication between slur and phrasing slur engravers.
http://code.google.com/p/lilypond/issues/detail?id=2689

Avoid duplication between slur and phrasing slur engravers.

The original code in slur-engraver.cc contained a comment:

  This is largely similar to Phrasing_slur_engraver. Check if fixes
  apply there too.

  (on principle, engravers don't use inheritance for code sharing)

This patch violates that principle.  However, it uses neither multiple
inheritance nor virtual base classes nor templates for this, but just
a common base class with virtual functions.

http://codereview.appspot.com/6432059




reply via email to

[Prev in Thread] Current Thread [Next in Thread]