Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long

[Paulo César Pereira de Andrade]

Em sex, 4 de out de 2019 às 17:38, Paul Cercueil
<address@hidden> escreveu:
>
> Hi Paulo,

  Hi Paul,

> Le ven., oct. 4, 2019 at 14:40, Paulo César Pereira de Andrade
> <address@hidden> a écrit :
> > Em qui, 3 de out de 2019 às 17:56, Zachary Cook
> > <address@hidden> escreveu:
> > [...]
> >>>    Just pushed an alternate patch to use jit_word_t instead of long.
> >>>  Please check. But there might be issues with literals, that would
> >>> need
> >>>  a 'LL' modifier.
> >>>
> >>  Yep that patch works too, same 9 more tests pass.
> >
> >   Please test with the latest git commit.
> >
> > I corrected the previous patches, because:
> > o MinGW does not define __CYGWIN__, and __CYGWIN__ 64 bit became
> > broken.
>
> But Cygwin still defines _WIN32, no?

  Maybe very recent Cygwin might define. I am using a non updated
for 2 years environment for testing and it does not define _WIN32.
Well, msys2 when not using a mingw64 shell does not define either,
so things should not have changed.
  Either way, probably it should be required to change from _WIN32
to __LLP64__ or equivalent at some point.

> > o check/lightning.c needs to call strtoull instead of strtoul to read
> >   constants.
> > o There were incorrect register mappings left in previous patches.
> >
> > I believe I tested in an environment as close as possible to the one
> > you
> > are testing, and all tests pass.
> >
> > I suppose the msys2 using mingw32 is passing all tests, but did not
> > verify it (did not install all packages, etc).

Thanks,
Paulo