libunwind-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libunwind-devel] [PATCH 5/5] Search MiniDebugInfo for procedure nam


From: Arun Sharma
Subject: Re: [Libunwind-devel] [PATCH 5/5] Search MiniDebugInfo for procedure names
Date: Sat, 11 Aug 2012 21:34:35 -0700

On Fri, Aug 10, 2012 at 7:03 AM, Martin Milata <address@hidden> wrote:

>
> +      /* Closer symbol was found (possibly truncated). */
> +      if (ret_mdi == 0 || ret_mdi == -UNW_ENOMEM)
> +       {
> +         ret = ret_mdi;
> +       }
> +
> +      munmap (mdi.image, mdi.size);

If the second lookup fails with -UNW_ENOMEM, looks like you propagate
that error up the stack. Why not propagate the best known answer from
the first lookup?

 -Arun



reply via email to

[Prev in Thread] Current Thread [Next in Thread]