[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to l
From: |
Denys Vlasenko |
Subject: |
Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind |
Date: |
Fri, 16 Mar 2012 13:53:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/15/2012 07:32 PM, Arun Sharma wrote:
On Thu, Mar 15, 2012 at 10:57 AM, Denys Vlasenko<address@hidden> wrote:
You say that it's wrong to call it *dwarf*_find_unwind_table
and put it into src/dwarf/*.
I'm ok with it.
Where do you think is the best place to have it?
I'll move it there.
How about moving the ia64 find_unwind_table to its own file under
src/ptrace? Then you can then share it via #include in
src/coredump/_UPT*.
Well... this would create a bad situation where
libunwind-coredump.a library either requires libunwind-ptrace.a,
or includes a copy of part of it.
I want this code to end up in libunwind.so instead,
so we can use it equally from both libs.
Our predicament seems to be that we have no good
place to put its source in the source tree, right?
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 arm
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 hppa
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 ia64
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 mi
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 mips
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 ppc
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 ppc32
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 ppc64
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 x86
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 x86_64
The above dirs are arch specific - not suitable.
drwxr-xr-x. 2 root root 4096 Feb 24 11:36 coredump
drwxr-xr-x. 2 root root 4096 Feb 21 16:51 ptrace
Sources of libunwind-coredump.a and libunwind-ptrace.a -
not good too, we want to share it between them, that's
the whole point.
drwxr-xr-x. 2 root root 4096 Feb 21 17:21 dwarf
But this function has nothing to do with dwarf...
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 setjmp
It is unrelated to setjmp'ing too...
This leaves us with the only remaining source dir:
drwxr-xr-x. 2 root root 4096 Feb 13 18:43 unwind
Can we put it into this dir?
If not, let's just create a new one, say common/*,
for the miscellaneous shared code bits...
What do you say?
--
vda
- Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind, Arun Sharma, 2012/03/06
- Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind, Denys Vlasenko, 2012/03/07
- Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind, Denys Vlasenko, 2012/03/15
- Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind, Arun Sharma, 2012/03/15
- Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind,
Denys Vlasenko <=
- Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind, Arun Sharma, 2012/03/24
- Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind, Denys Vlasenko, 2012/03/29
- Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind, Arun Sharma, 2012/03/29