Re: [Libunwind-devel] [PATCH 2/8] Always validate all addresses.

[Lassi Tuura]

Hi,

>> Force address validation on x86-64 to avoid frequent crashes, caused
>> both by .eh_frame info inaccuracies and current libunwind limitations.
>> It is not sufficient to validate only in or after signal frames.
>>> 
>> 
> 
> Could you make this a compile time option?

Like this? Updated patch + knock-on update in another patch in the series.

Subject: [PATCH 1/2] Always validate all addresses.
From: Lassi Tuura <address@hidden>
Date: Thu, 22 Apr 2010 16:38:13 +0200

Force address validation on x86-64 to avoid frequent crashes, caused
both by .eh_frame info inaccuracies and current libunwind limitations.
It is not sufficient to validate only in or after signal frames.
---
configure.in             |    6 ++++++
src/x86_64/Ginit_local.c |    4 ++++
2 files changed, 10 insertions(+), 0 deletions(-)

igprof-x64-strict-validate.patch
Description: Text document

Subject: [PATCH 2/2] Correct choice of next or previous instruction.
From: Lassi Tuura <address@hidden>
Date: Thu, 22 Apr 2010 16:38:18 +0200

---
include/dwarf.h           |    1 +
src/arm/Ginit_local.c     |    2 +-
src/arm/Ginit_remote.c    |    2 +-
src/arm/init.h            |    3 ++-
src/dwarf/Gparser.c       |   36 +++++++++++++++++++++++++++++++++---
src/hppa/Ginit_local.c    |    2 +-
src/hppa/Ginit_remote.c   |    2 +-
src/hppa/init.h           |    4 +++-
src/mips/Ginit_local.c    |    2 +-
src/mips/Ginit_remote.c   |    2 +-
src/mips/init.h           |    3 ++-
src/ppc/Ginit_local.c     |    4 ++--
src/ppc/Ginit_remote.c    |    4 ++--
src/ppc32/init.h          |    3 ++-
src/ppc64/init.h          |    3 ++-
src/x86/Ginit_local.c     |    2 +-
src/x86/Ginit_remote.c    |    2 +-
src/x86/init.h            |    3 ++-
src/x86_64/Ginit_local.c  |    2 +-
src/x86_64/Ginit_remote.c |    2 +-
src/x86_64/init.h         |    3 ++-
21 files changed, 63 insertions(+), 24 deletions(-)

igprof-ip-address.patch
Description: Text document