[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] Get Function Address Patch
From: |
Jose Flavio Aguilar Paulino |
Subject: |
Re: [Libunwind-devel] Get Function Address Patch |
Date: |
Thu, 23 Aug 2007 12:35:04 -0300 |
On Wed, 2007-08-22 at 13:07 -0600, David Mosberger-Tang wrote:
> Jose,
>
> I checked in a patch to support the tdep_get_func_addr() hook you
> need. I didn't check in the changes to the distance-checking so far.
> Something seems fishy there. In your patch, you check "cur_dist < 0",
> but cur_dist is of type "Elf_W(Addr)", which should be an unsigned
> type, AFAIK, so the check makes no sense.
Sorry me David, what a wanted to was this:
...
cur_dist = (Elf_W (Addr)) (ip - val);
if (unlikely (val < ip))
continue;
...
just a sanity/optimization check,
but you are right I can't use the cur_dist value!
Do you want to send a correct version of the patch?
Thanks for reviewing it!
--
Jose Flavio Aguilar Paulino
Toolchain Team
Software Engineer
IBM - Ltc Brazil
- [Libunwind-devel] Get Function Address Patch, Jose Flavio Aguilar Paulino, 2007/08/20
- Re: [Libunwind-devel] Get Function Address Patch, David Mosberger-Tang, 2007/08/22
- Re: [Libunwind-devel] Get Function Address Patch,
Jose Flavio Aguilar Paulino <=
- Re: [Libunwind-devel] Get Function Address Patch, David Mosberger-Tang, 2007/08/23
- Re: [Libunwind-devel] Get Function Address Patch, Jose Flavio Aguilar Paulino, 2007/08/23
- Re: [Libunwind-devel] Get Function Address Patch, David Mosberger-Tang, 2007/08/23
- [Libunwind-devel] How to build for PowerPC64, Jose Flavio Aguilar Paulino, 2007/08/23
- Re: [Libunwind-devel] How to build for PowerPC64, David Mosberger-Tang, 2007/08/23