Re: -no_fixup_chains patch

[Ileana Dumitrescu]

On 04/07/2024 20:55, Gary V. Vaughan wrote:
> > On Jul 2, 2024, at 12:01 PM, Václav Haisman <vhaisman@gmail.com> wrote:
> >
> > On 28. 06. 24 0:41, Ozkan Sezer wrote:
> > > [Sorry, I seem to have deleted the mailing list message from my inbox]
> > > Regarding -no_fixup_chains patch i.e.
> > >  
> > > http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=commitdiff;h=3d1baeeef90a6b9e16c545babe833f28dca155a7
> > > Is '+=' universally supported?? Maybe change to something like the 
> > > following??
> >
> > Is there a reason not to use AS_VAR_APPEND? 
> > (https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Polymorphic-Variables.html)
> >
> > > diff --git a/m4/libtool.m4 b/m4/libtool.m4
> > > index 381d4cb..31f1be0 100644
> > > --- a/m4/libtool.m4
> > > +++ b/m4/libtool.m4
> > > @@ -1032,3 +1032,3 @@
> > >        [ save_LDFLAGS=$LDFLAGS
> > > -        LDFLAGS+=" -Wl,-no_fixup_chains"
> > > +        LDFLAGS="$LDFLAGS -Wl,-no_fixup_chains"
> > >          AC_LINK_IFELSE(
> > > @@ -1093,3 +1093,3 @@ _LT_EOF
> > >            if test yes = "$lt_cv_support_no_fixup_chains"; then
> > > -            _lt_dar_allow_undefined+=' $wl-no_fixup_chains'
> > > +            _lt_dar_allow_undefined='$_lt_dar_allow_undefined
> > > $wl-no_fixup_chains'
> > >            fi
>
> AS_VAR_APPEND goes through a lot of setup at Libtool build-time, and 
> eventually ends up calling a shell function as_fn_append at runtime 
> anyway.   Since Libtool includes funclib.sh, it would be simpler to use 
> func_append in this case: 
> https://github.com/gnulib-modules/bootstrap/blob/master/build-aux/funclib.sh#L532-L549 <https://github.com/gnulib-modules/bootstrap/blob/master/build-aux/funclib.sh#L532-L549>

It is simpler than AS_VAR_APPEND, and it still includes the ability
to utilize the '+=' extension, which I do prefer. I have attached a 
proposed patch for this implementation. Unless there is an issue with
including the functionality of funclib.sh in libtool.m4, I will apply
this patch early next week.

The actual issue with appending the '-no_fixup_chains' option should
be fixed at this point, so I will close that [1].

[1] https://savannah.gnu.org/support/index.php?111069

--
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

0001-m4-Utilize-bootstrap-s-func_append.patch
Description: Text Data

OpenPGP_0x6570EA01146F7354.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature