Re: [patch #9442] Add flang (LLVM-based compiler) support

[Roumen Petrov]

Hi,


Mike Frysinger wrote:
> Update of patch#9442 (group libtool):
>
>                    Status:                    None => Done
>               Open/Closed:                    Open => Closed
>
>      _______________________________________________________
>
> Follow-up Comment #1:
>
> i dropped the -DPIC part as no other target does it, and i think we handle
> that in common code already.  feel free to follow up if you disagree.

Please note that by default libtool build shared and static objects .
When is build shared object -DPIC is set internally for shared build.
So to remove -DPIC looks harmless.

I guess that reporter could check this. See libtool manual:
...

Notice that the second run of GCC has its output discarded. This is done so 
that compiler warnings aren’t annoyingly duplicated. If you need to see both 
sets of warnings (you might have conditional code inside ‘#ifdef PIC’ for 
example), you can turn off suppression with the -no-suppress option to 
libtool’s compile mode:

burger$libtool --mode=compile gcc -no-suppress -g -O -c hello.c
gcc -g -O -c hello.c  -fPIC -DPIC -o .libs/hello.o
gcc -g -O -c hello.c -o hello.o
burger$
....




Regards,
Roumen Petrov