libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #9361] libtool.m4: preload valid C symbol names only


From: Michael Haubenwallner
Subject: [patch #9361] libtool.m4: preload valid C symbol names only
Date: Fri, 26 May 2017 14:30:25 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

URL:
  <http://savannah.gnu.org/patch/?9361>

                 Summary: libtool.m4: preload valid C symbol names only
                 Project: GNU Libtool
            Submitted by: haubi
            Submitted on: Fri 26 May 2017 08:30:24 PM CEST
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Hi,

the current $global_symbol_pipe for 'MS dumpbin' yields symbol names starting
with @ or ? on purpose.

As these symbol names are not valid C symbol names, this breaks following test
cases with 64bit MSVC compiler, and even with 32bit since MSVC 14 (=VS 2015):

 27: link against a preloaded static library
 28: build and dynamically load a module
 29: preload static and dynamic module
 31: disable fast install
 32: force PIC objects
 34: hardcoding library path
 36: uninstalled libraries have priority
 37: linking with long file names

Attached patches does fix these test cases for 64bit MSVC (tested 10.0, 12.0,
14.0, 15.0) as well as for 32bit MSVC 14.0 and 15.0 (=VS 2017), in that it
does accept only valid C symbol names for ltdl preloading.

Thanks!
/haubi/



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 26 May 2017 08:30:24 PM CEST  Name:
0001-libtool.m4-preload-valid-C-symbol-names-only.patch  Size: 3kB   By: haubi

<http://savannah.gnu.org/patch/download.php?file_id=40796>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9361>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]