Re: [Liberty-eiffel] serial device

[Cyril ADRIAN]

Hi Raphael,

2014-05-28 22:19 GMT+02:00 Raphael Mack <address@hidden>:

Mh, this was not SOO successful ;-)

I saw that :-D

 

I damaged the SEGC, as it uses
structs with the name Bxxx where xxx is the type ID, right? and this
leads to a name clash when including termios.h, which defines the speed
constants Bxxx.

I'd like to rename the GC structs and replace the B names by GC_B.

Yes. Good idea.

Another topic which came to my mind is the question, whether it was a
good decision to add the C defines and the termios.h include directly to
io.h. Currently I tend to move this to a separate termios-plugin, to
have the termios.h include only when the TERMINAL_SETTINGS are used...

What do you think?

I agree. In a good OOP world try to separate concerns, even in plugins ;-)

PS- I'll be offline for a few days.

Cheers,

Cyril