[Koha-cvs] koha/C4 Circulation.pm Members.pm Reserves.pm

[Antoine Farnault]

CVSROOT:        /sources/koha
Module name:    koha
Changes by:     Antoine Farnault <toins>        07/07/12 15:22:10

Modified files:
        C4             : Circulation.pm Members.pm Reserves.pm 

Log message:
        using 'our' instead of 'use vars' which is deprecated.
        removing some compilation warns.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/C4/Circulation.pm?cvsroot=koha&r1=1.29&r2=1.30
http://cvs.savannah.gnu.org/viewcvs/koha/C4/Members.pm?cvsroot=koha&r1=1.55&r2=1.56
http://cvs.savannah.gnu.org/viewcvs/koha/C4/Reserves.pm?cvsroot=koha&r1=1.15&r2=1.16

Patches:
Index: Circulation.pm
===================================================================
RCS file: /sources/koha/koha/C4/Circulation.pm,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -b -r1.29 -r1.30
--- Circulation.pm      1 Jul 2007 23:56:43 -0000       1.29
+++ Circulation.pm      12 Jul 2007 15:22:09 -0000      1.30
@@ -17,7 +17,7 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-# $Id: Circulation.pm,v 1.29 2007/07/01 23:56:43 rangi Exp $
+# $Id: Circulation.pm,v 1.30 2007/07/12 15:22:09 toins Exp $
 
 use strict;
 require Exporter;
@@ -42,10 +42,10 @@
 use C4::Branch; # GetBranches
 use C4::Log; # logaction
 
-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
+our ($VERSION,@ISA,@EXPORT,@EXPORT_OK,%EXPORT_TAGS);
 
 # set the version for version checking
-$VERSION = do { my @v = '$Revision: 1.29 $' =~ /\d+/g; shift(@v).".".join( 
"_", map { sprintf "%03d", $_ } @v ); };
+$VERSION = do { my @v = '$Revision: 1.30 $' =~ /\d+/g; shift(@v).".".join( 
"_", map { sprintf "%03d", $_ } @v ); };
 
 =head1 NAME
 

Index: Members.pm
===================================================================
RCS file: /sources/koha/koha/C4/Members.pm,v
retrieving revision 1.55
retrieving revision 1.56
diff -u -b -r1.55 -r1.56
--- Members.pm  8 Jul 2007 23:07:31 -0000       1.55
+++ Members.pm  12 Jul 2007 15:22:09 -0000      1.56
@@ -17,7 +17,7 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-# $Id: Members.pm,v 1.55 2007/07/08 23:07:31 rangi Exp $
+# $Id: Members.pm,v 1.56 2007/07/12 15:22:09 toins Exp $
 
 use strict;
 require Exporter;
@@ -29,9 +29,9 @@
 use C4::Overdues;
 use C4::Reserves;
 
-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK);
+our ($VERSION,@ISA,@EXPORT,@EXPORT_OK);
 
-$VERSION = do { my @v = '$Revision: 1.55 $' =~ /\d+/g; shift(@v) . "." . join( 
"_", map { sprintf "%03d", $_ } @v ); };
+$VERSION = do { my @v = '$Revision: 1.56 $' =~ /\d+/g; shift(@v) . "." . join( 
"_", map { sprintf "%03d", $_ } @v ); };
 
 =head1 NAME
 
@@ -1637,7 +1637,7 @@
        FROM borrowers
        WHERE borrowernumber = ?
    ";
-    my $sth = $dbh->prepare($query);
+    $sth = $dbh->prepare($query);
     $sth->execute($borrowernumber);
     $sth->finish;
     
&logaction(C4::Context->userenv->{'number'},"MEMBERS","DELETE",$borrowernumber,"")
 

Index: Reserves.pm
===================================================================
RCS file: /sources/koha/koha/C4/Reserves.pm,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -b -r1.15 -r1.16
--- Reserves.pm 12 Jul 2007 12:51:34 -0000      1.15
+++ Reserves.pm 12 Jul 2007 15:22:09 -0000      1.16
@@ -20,7 +20,7 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-# $Id: Reserves.pm,v 1.15 2007/07/12 12:51:34 hdl Exp $
+# $Id: Reserves.pm,v 1.16 2007/07/12 15:22:09 toins Exp $
 
 use strict;
 require Exporter;
@@ -29,11 +29,12 @@
 use C4::Search;
 use C4::Circulation;
 
-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
+our ($VERSION,@ISA,@EXPORT,@EXPORT_OK,%EXPORT_TAGS);
+
 my $library_name = C4::Context->preference("LibraryName");
 
 # set the version for version checking
-$VERSION = do { my @v = '$Revision: 1.15 $' =~ /\d+/g; shift(@v) . "." . join( 
"_", map { sprintf "%03d", $_ } @v ); };
+$VERSION = do { my @v = '$Revision: 1.16 $' =~ /\d+/g; shift(@v) . "." . join( 
"_", map { sprintf "%03d", $_ } @v ); };
 
 =head1 NAME
 
@@ -45,7 +46,7 @@
 
 =head1 DESCRIPTION
 
-this modules provides somes functions to deal with reservations.
+  this modules provides somes functions to deal with reservations.
 
 =head1 FUNCTIONS
 
@@ -61,12 +62,12 @@
   &GetReservesFromItemnumber
   &GetReservesFromBiblionumber
   &GetReservesFromBorrowernumber
-  GetReservesForBranch
-  GetReservesToBranch
+  &GetReservesForBranch
+  &GetReservesToBranch
   &GetReserveCount
   &GetReserveFee
-  GetReservesForBranch
-  GetReservesToBranch
+  &GetReservesForBranch
+  &GetReservesToBranch
   &GetOtherReserves
   
   &ModReserveFill
@@ -83,7 +84,7 @@
 
 =item AddReserve
 
-AddReserve($branch,$borrowernumber,$biblionumber,$constraint,$bibitems,$priority,$notes,$title,$checkitem,$found)
+    
AddReserve($branch,$borrowernumber,$biblionumber,$constraint,$bibitems,$priority,$notes,$title,$checkitem,$found)
 
 =cut
 
@@ -245,6 +246,14 @@
     return ( $#results + 1, address@hidden );
 }
 
+=item GetReservesFromItemnumber
+
+ ( $reservedate, $borrowernumber, $branchcode ) = 
GetReservesFromItemnumber($itemnumber);
+
+   TODO :: Description here
+
+=cut
+
 sub GetReservesFromItemnumber {
     my ( $itemnumber ) = @_;
     my $dbh   = C4::Context->dbh;
@@ -261,6 +270,13 @@
     return ( $reservedate, $borrowernumber, $branchcode );
 }
 
+=item GetReservesFromBorrowernumber
+
+       $borrowerreserv = GetReservesFromBorrowernumber($borrowernumber,$tatus);
+       
+       TODO :: Descritpion
+=cut
+
 sub GetReservesFromBorrowernumber {
     my ( $borrowernumber, $status ) = @_;
     my $dbh   = C4::Context->dbh;
@@ -369,6 +385,14 @@
     return ( $messages, $nextreservinfo );
 }
 
+=item GetReserveFee
+
+$fee = GetReserveFee($borrowernumber,$biblionumber,$constraint,$biblionumber);
+
+Calculate the fee for a reserve
+
+=cut
+
 sub GetReserveFee {
     my ($borrowernumber, $biblionumber, $constraint, $bibitems ) = @_;
 
@@ -463,12 +487,10 @@
             }
         }
     }
-
-    #  print "fee $fee";
     return $fee;
 }
 
-=head2 GetReservesToBranch
+=item GetReservesToBranch
 
 @transreserv = GetReservesToBranch( $frombranch );
 
@@ -497,7 +519,7 @@
     return (@transreserv);
 }
 
-=head2 GetReservesForBranch
+=item GetReservesForBranch
 
 @transreserv = GetReservesForBranch($frombranch);
 
@@ -1088,14 +1110,6 @@
     return @results;
 }
 
-=item GetReserveFee
-
-$fee = GetReserveFee($borrowernumber,$biblionumber,$constraint,$biblionumber);
-
-Calculate the fee for a reserve
-
-=cut
-
 =back
 
 =head1 AUTHOR