[Koha-cvs] koha/C4 Serials.pm

[Henri-Damien LAURENT]

CVSROOT:        /cvsroot/koha
Module name:    koha
Changes by:     Henri-Damien LAURENT <hdl>      07/06/27 15:10:45

Modified files:
        C4             : Serials.pm 

Log message:
        Bug Fixing.
        An inconsistency in function signature caused a shift between date 
received and publication date.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/C4/Serials.pm?cvsroot=koha&r1=1.21&r2=1.22

Patches:
Index: Serials.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Serials.pm,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -b -r1.21 -r1.22
--- Serials.pm  27 Jun 2007 14:54:55 -0000      1.21
+++ Serials.pm  27 Jun 2007 15:10:44 -0000      1.22
@@ -17,7 +17,7 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-# $Id: Serials.pm,v 1.21 2007/06/27 14:54:55 hdl Exp $
+# $Id: Serials.pm,v 1.22 2007/06/27 15:10:44 hdl Exp $
 
 use strict;
 use C4::Date;
@@ -35,7 +35,7 @@
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
 
 # set the version for version checking
-$VERSION = do { my @v = '$Revision: 1.21 $' =~ /\d+/g;
+$VERSION = do { my @v = '$Revision: 1.22 $' =~ /\d+/g;
     shift(@v) . "." . join( "_", map { sprintf "%03d", $_ } @v );
 };
 
@@ -1153,7 +1153,7 @@
 
 =over 4
 
-ModSerialStatus($serialid,$serialseq, 
$publisheddate,$planneddate,$status,$notes)
+ModSerialStatus($serialid,$serialseq, 
$planneddate,$publisheddate,$status,$notes)
 
 This function modify the serial status. Serial status is a number.(eg 2 is 
"arrived")
 Note : if we change from "waited" to something else,then we will have to 
create a new "waited" entry
@@ -1163,7 +1163,7 @@
 =cut
 
 sub ModSerialStatus {
-    my ( $serialid, $serialseq, $publisheddate, $planneddate, $status, $notes )
+    my ( $serialid, $serialseq,  $planneddate,$publisheddate, $status, $notes )
       = @_;
 
     #It is a usual serial
@@ -1442,23 +1442,23 @@
       = @_;
     my $dbh          = C4::Context->dbh;
     my $subscription = GetSubscription($subscriptionid);
-#     my $query        = qq|
-#         SELECT *
-#         FROM   biblio,biblioitems
-#         WHERE  biblio.biblionumber=biblioitems.biblionumber
-#         AND    biblio.biblionumber=?
-#     |;
-#     my $sth = $dbh->prepare($query);
-#     $sth->execute( $subscription->{biblionumber} );
-#     my $biblio = $sth->fetchrow_hashref;
-#     NewSuggestion(
-#         $user,             $subscription->{bibliotitle},
-#         $biblio->{author}, $biblio->{publishercode},
-#         $biblio->{note},   '',
-#         '',                '',
-#         '',                '',
-#         $subscription->{biblionumber}
-#     );
+     my $query        = qq|
+         SELECT *
+         FROM   biblio,biblioitems
+         WHERE  biblio.biblionumber=biblioitems.biblionumber
+        AND    biblio.biblionumber=?
+     |;
+     my $sth = $dbh->prepare($query);
+     $sth->execute( $subscription->{biblionumber} );
+     my $biblio = $sth->fetchrow_hashref;
+     NewSuggestion(
+         $user,             $subscription->{bibliotitle},
+         $biblio->{author}, $biblio->{publishercode},
+         $biblio->{note},   '',
+         '',                '',
+         '',                '',
+         $subscription->{biblionumber}
+     );
 
     # renew subscription
     my $query = qq|
@@ -1478,7 +1478,7 @@
 
 =over 4
 
-NewIssue($serialseq,$subscriptionid,$biblionumber,$status, $publisheddate, 
$planneddate)
+NewIssue($serialseq,$subscriptionid,$biblionumber,$status, $planneddate, 
$publisheddate,  $notes)
 
 Create a new issue stored on the database.
 Note : we have to update the recievedlist and missinglist on 
subscriptionhistory for this subscription.