[Koha-cvs] CVS: koha/misc Install.pm,1.20,1.21

[Ambrose Li]

Update of /cvsroot/koha/koha/misc
In directory sc8-pr-cvs1:/tmp/cvs-serv29412/misc

Modified Files:
        Install.pm 
Log Message:
If $noclear in showmessage is undef, default it to zero to avoid Perl
warnings.

Removed a few FIXME notes after moving them to bugs.koha.org


Index: Install.pm
===================================================================
RCS file: /cvsroot/koha/koha/misc/Install.pm,v
retrieving revision 1.20
retrieving revision 1.21
diff -C2 -r1.20 -r1.21
*** Install.pm  25 Jan 2003 17:20:50 -0000      1.20
--- Install.pm  25 Jan 2003 17:39:10 -0000      1.21
***************
*** 483,502 ****
  screen-clearing is not done.
  
- FIXME: A response type of "yn" should allow the user to specify
- "y" or "n" in either uppercase or lowercase. This is especially
- true since the message shown to the user will contain uppercase
- characters as valid choices.
- 
- FIXME: If the response type is "free", the user cannot specify
- an empty string; showmessage will return "1" as the result.
- 
- FIXME: A default response of "0" cannot be specified. This is
- wrong; the default response should be checked for undef, not
- for 0.
- 
- FIXME: If $noclear is not specified or specified as undef, we
- just test it for a non-zero value without testing it for being
- undef first.
- 
  =cut
  
--- 483,486 ----
***************
*** 506,509 ****
--- 490,494 ----
      my $defaultresponse=shift;
      my $noclear=shift;
+     $noclear = 0 unless defined $noclear; # defaults to "clear"
      ($noclear) || (system('clear'));
      if ($responsetype =~ /^yn$/) {