js-shield
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MV3 JShelter Chrome Release


From: Giorgio Maone
Subject: Re: MV3 JShelter Chrome Release
Date: Mon, 22 Jul 2024 22:49:47 +0200
User-agent: Mozilla Thunderbird

Hi Libor,

I've fixed some more bug (especially a couple preventing the popup from opening on MV3) rebased and force pushed (https://pagure.io/JShelter/webextension/tree/mv3).

However when I tried to open the PR I've promised I repeatedly got a 500 Server error from pagure here: https://pagure.io/JShelter/webextension/diff/main..mv3

This didn't happen on other branches, so I'm a bit puzzled.

However, unless you or Michael know what's going on with pagure, we can comment and amend the old way, through email/issues and plain old git.

Thanks and best
-- G

On 22/07/24 19:06, Giorgio Maone wrote:
I've just force-pushed (on both branches) a more testable version.

I'm sure there are bugs because the changes are huge, conceptually and the Chrome API themselves are still buggy and unstable.

I'd also like to make more explicit to users (maybe in the UI on startup?) that MV3at this moment requires JShelter (like any other extension based on dynamic script injections, like GreaseMonkey) to have users turn on the development mode toggle: see https://developer.chrome.com/docs/extensions/reference/api/userScripts#developer_mode_for_extensions_users

So expect me to push more changes later today and tomorrow.

 I've notice noticed that debug versions (compiled with "make debug") causes infinite recursion errors in the content wrappers on Chrome (where the debugging code calls wrapped APIs like performance.now() from within the wrapper). Not sure whether it's a MV3-specific bug or it's already been happening in previous Chrome versions, but I'll get to it after any other more user-facing fix.

Thanks and best,
-- G

On 22/07/24 13:44, Libor Polčák wrote:
Saturday I've pushed both mv3 branches (JShelter and nscl) on their respective repositories.

Hello Giorgio,

I wanted to try before

However some more changes are needed to make Chrome's userScripts API work for us, which I plan to commit and push later today (afternoon or evening).

However, I cannot build the extension:

git submodule init
git submodule update
fatal: transport 'file' not allowed
fatal: Fetched in submodule path 'nscl', but it did not contain ac6785866c7cd2bb29654cbaa621531d35273131. Direct fetching of that commit failed.

It looks like JShelter refers to a non-existing commit in NSCL.

Libor







reply via email to

[Prev in Thread] Current Thread [Next in Thread]