[Jailkit-dev] configure.ac: warnings with autoconf >= 2.70 and issues in manpage

[Eriberto]

Hi guys,

Debian 11 "Bullseye" was released some hours ago and the freeze stage
has ended. I will upload jailkit 2.22 to Debian unstable now. In few
days (after 2.22 arrives at Debian testing), I will upload 2.22 to
stable-backports.

There are 3 issues in version 2.22.

1. From Debian Sid using autoconf 2.71:

-----------------------
configure.ac:49: warning: The macro `AC_CONFIG_HEADER' is obsolete.
configure.ac:49: You should run autoupdate.
./lib/autoconf/status.m4:719: AC_CONFIG_HEADER is expanded from...
configure.ac:49: the top level
configure.ac:51: warning: The macro `AC_GNU_SOURCE' is obsolete.
configure.ac:51: You should run autoupdate.
./lib/autoconf/specific.m4:312: AC_GNU_SOURCE is expanded from...
configure.ac:51: the top level
configure.ac:54: warning: The macro `AC_ISC_POSIX' is obsolete.
configure.ac:54: You should run autoupdate.
./lib/autoconf/specific.m4:550: AC_ISC_POSIX is expanded from...
configure.ac:54: the top level
configure.ac:66: warning: The macro `AC_HEADER_STDC' is obsolete.
configure.ac:66: You should run autoupdate.
./lib/autoconf/headers.m4:704: AC_HEADER_STDC is expanded from...
configure.ac:66: the top level
-----------------------

The command `autoupdate' will help to solve some issues.

2. The manpage jailkit.7 has the line '.TH jailkit 8 07-02-2010
JAILKIT jailkit', instead of '.TH jailkit 7 07-02-2010 JAILKIT
jailkit'

Also, the Makefile (automake) is installing a duplicate manpage in
man7/man8. See below:

-----------------------
make[1]: Entering directory '/tmp/jailkit/jailkit/man'
/usr/bin/install -c -d -m 755 /usr/share/man/man8/
for file in jailkit.7 jk_chrootsh.8.gz jk_uchroot.8.gz jk_lsh.8.gz
jk_socketd.8.gz jk_init.8.gz jk_check.8.gz jk_cp.8.gz
jk_chrootlaunch.8.gz jk_jailuser.8.gz jk_list.8.gz jk_update.8.gz ; do
\
        /usr/bin/install -c -m 0644 ${file} /usr/share/man/man8/ ;\
done
/usr/bin/install -c -d -m 755 /usr/share/man/man7/
/usr/bin/install -c -m 0644 jailkit.7.gz /usr/share/man/man7/
make[1]: Leaving directory '/tmp/jailkit/jailkit/man'
-----------------------

# find /usr/share/man -name 'jailkit*'
/usr/share/man/man7/jailkit.7.gz
/usr/share/man/man8/jailkit.7

3. When building, the following messages are displayed:

gcc -g -O2 -ffile-prefix-map=/PKGS/BOOKWARM/jailkit/jailkit=.
-fstack-protector-strong -Wformat -Werror=format-security -Wall -pipe
-pthread -DINIPREFIX=\"/etc/jailkit\" -Wdate-time -D_FORTIFY_SOURCE=2
-c -o jk_lsh.o jk_lsh.c
In file included from /usr/include/string.h:495,
                 from jk_lsh.c:58:
In function ‘strncpy’,
    inlined from ‘expand_executable_w_path’ at jk_lsh.c:128:14,
    inlined from ‘main’ at jk_lsh.c:296:8:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning:
‘__builtin_strncpy’ specified bound depends on the length of the
source argument [-Wstringop-overflow=]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jk_lsh.c: In function ‘main’:
jk_lsh.c:125:15: note: length computed here
  125 |    int tlen = strlen(*path);
      |               ^~~~~~~~~~~~~

If you release a new version, I will upload it to
unstable/stable-backports immediately.

Thanks for your nice work!

Cheers,

Eriberto