Re: [Jailkit-dev] jailkit sent to Debian -- comments

[Olivier Sessink]

On 19-10-19 04:07, Eriberto wrote:
> Hi guys,
>
> Today I sent jailkit-2.21 to Debian. Considering that is first time of
> jailkit in Debian, now it is in NEW queue[1] to be analised by
> FTP-Master Team. The wait time is 1 day up to 3 months. There is a
> copy of the package in our git repository[2].

great! many thanks!

answers inline:

> [1] https://ftp-master.debian.org/new.html
> [2] https://salsa.debian.org/debian/jailkit
>
> I found some issues and I would like to tell about it.
>
> 1. The configure.ac forces to install Python 2.

it works here with python 3.6 ?

PYTHONINTERPRETER=/usr/bin/python3.6 ./configure


> 2. There are some spelling errors (detected by me or by lintian, the
> Debian build system check). I did a patch[3] to fix it.
>
> [3] 
> https://salsa.debian.org/debian/jailkit/blob/debian/master/debian/patches/20_fix-spelling-manpages.patch
>
> 3. When running "# jk_init -v -j /home/chrootusers ssh", I got:
> "configparser.DuplicateOptionError: While reading from
> '/etc/jailkit/jk_init.ini' [line 118]: option 'includesections' in
> section 'openvpn' already exists". This patch[4] will fix it.
>
> [4] 
> https://salsa.debian.org/debian/jailkit/blob/debian/master/debian/patches/30_remove-duplicate-option.patch

thanks, committed both patches!

> 4. The website[5] says: "The old (<2.20) releases are signed with PGP
> key DAC576E6. Releases since 2.20 are signed with key F18D32B9".
> However:
>
> $ gpg --verify jailkit-2.21.tar.gz.sig
> gpg: assuming signed data in 'jailkit-2.21.tar.gz'
> gpg: Signature made dom 29 set 2019 17:39:24 -03
> gpg:                using RSA key 58FD02766D031E832560A6A226073EFCDAC576E6

whoops, fixed that, they are not signed with the correct key


> 5. The Debian lintian shows:
>
> jailkit source: source-contains-prebuilt-python-object
> py/__pycache__/jk_lib.cpython-37.pyc

obviously I didn't clean before I made the tarball...

> 6. There are some warnings when building with GCC 9:


I think they should be gone now. Only one was real, the others where
handled somewhere else in the code.


> Thanks a lot for your nice work. We will have jailkit approved in Debian soon.
>
many thanks to you also!

It is great if jailikit will be evailable from Debian!

Olivier


-- 
Bluefish website http://bluefish.openoffice.nl/
Blog http://oli4444.wordpress.com/