Re: RedHat/Fedora patches (Was: Re: [mtools] Mtools 3.9.10 for VMS)

[Alain Knaff]

Moritz Barsnick wrote:
> Hi,
>
> Alain wrote:
> > Moritz Barsnick wrote:
> > > BTW, Fedora core 5 (and other Linux distributions?) has a bunch of
> > > patches in the mtools code. Are they worth a look?
> > > mtools-3.9.6-config.patch
> > > mtools-3.9.6-paths.patch
> > > mtools-3.9.7-bigdisk.patch
> > > mtools-3.9.9-badc.patch
> > > mtools-3.9.9-noargs.patch
> > Judging from the version numbers, they look somewhat obsolete...
>
> Well, they still apply them against the current version. They just
> haven't re-built the patches.

ok. I looked at them, most of those 4 that you have attached seem still 
relevant and correct, with 1 exception:

> e) mtools-3.9.9-noargs.patch
>   - fixes case of missing arguments to scripts/mcomp, which is probably
>     fair. IMO there could be more fixes in that script (like "" around
>     vars).
> -> Should be used. Attached here.

While it's a good idea to do parameter checking and print a usage 
message, the usage message that they inserted is way of base...
It's a comparison script, so there really is not target or source.
Moreover, the way the script is written, there is no way to pass it 
mtools arguments (though I may fix that later on). And finally, if you 
pass multiple parameters to cmp, it compares those with each other, 
completely ignoring the DOS file input (read via mcopy).

So I replaced the usage message with one that actually makes sense.

I applied the other 3 patches as is.

The result is available as 
http://mtools.linux.lu/mtools-3.9.10-20060626.diff.gz from the mtools site

> I recommend that you check these attached patches and consider including
> them. From what I can see, these four look valid. (They all apply fine
> against your most recent 20060531 patch.)

Agreed (with exception of the noargs patch, as noted above)

> I will try to follow up with my personal patches when I get around to
> it. I have to check whether there was anything relevant there...

Please do. At that time, I may call a 3.9.11

Regards,

Alain
_______________________________________________
mtools mailing list
address@hidden
http://www.tux.org/mailman/listinfo/mtools