[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: locking entire tree for write
From: |
Derek Robert Price |
Subject: |
Re: locking entire tree for write |
Date: |
Tue, 14 Oct 2003 13:05:58 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
If nobody has any comments on this, I'm going to check in the correction
on feature soon.
Derek
Derek Robert Price wrote:
| Correct me if I am wrong, but there is no good reason for the
| lock_tree_for_write calls in admin.c, edit.c, and watch.c. The three
| files contain four calls and all are of the form:
|
| ~ lock_tree_for_write
| ~ start_recursion(...CVS_LOCK_NONE...)
| ~ Lock_Cleanup
|
| with no intervening calls. I believe that in all four locations this
| could be replaced with the single call to:
|
| ~ start_recursion(...CVS_LOCK_WRITE...)
|
| as cvs tag and rtag do and that this would be more efficient, allowing
| only a directory at a time to be locked rather than locking an entire
| tree for the duration of the entire operations.
|
| Just wanted to run this by the list before I changed those calls on
stable.
|
| Derek
- --
~ *8^)
Email: address@hidden
Get CVS support at <http://ximbiot.com>!
- --
The Pledge of Allegiance does not end with "Hail Satan".
The Pledge of Allegiance does not end with "Hail Satan".
The Pledge of Allegiance does not end with "Hail Satan"...
~ - Bart Simpson on chalkboard, _The Simpsons_
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org
iD8DBQE/jCz1LD1OTBfyMaQRAifIAJ4oOulFxl8WXw/4W88Ilb1PrjryrACfdAsc
00FG7P8eqKRos+7AlBX9X6E=
=kGBj
-----END PGP SIGNATURE-----