Re: "Triggers" & links to defect tracking systems

[Mark D. Baushke]

Hi David,

David wrote:
>What I was thinking of doing was using the loginfo hook to
>check the checkin comment to see that there is a PR number,
>and then verify that this is a valid PR with checkin approval
>(we've been having problems with some people checking in stuff
>without permission, and I'd rather put at least one tooth into
>the "don't do that" message).
>
>Does anybody foresee a problem with that?

When the loginfo trigger is run, the files have already been checked
into the repository.

If you want to deny someone the ability to do the checkin, then you
will need to exit with a non-zero return code either from any of the
directories commitinfo trigger or from the first directory of the
verifyinfo triggers. If you abort from other than the first directory
of the verifyinfo triggers, then the commit will no longer be atomic
for the change by the user as some of the files will have been
committed, but the others will be rejected.

        Enjoy!
        -- Mark