Re: inadequate/inconsisten 'help pkg' message; problems with downloading

[Sergei Steshenko]

Alas, my investigation shows more and more bugs.

In 'octave-3.4.2/share/octave/3.4.2/m/pkg/pkg.m' file one can see this
function:

   2236 function archdir = getarchdir (desc)
   2237   archdir = fullfile (desc.archprefix, getarch());
   2238 endfunction
.

Please note that the function has just _one_ argument: 'desc'.

Now quick grep:

"
address@hidden:~/junk> grep -P -n '\bgetarchdir\b' 
/mnt/sdb8/sergei/AFSWD_debug/20110601/octave-3.4.2/share/octave/3.4.2/m/pkg/pkg.m.original
830:      rm_rf (getarchdir (descriptions{i}));
839:        && dirempty (getarchdir (descriptions{i})))
842:      rm_rf (getarchdir (descriptions{i}));
998:      if (exist (getarchdir (desc)))
999:        rmpath (getarchdir (desc));
1007:      [status, msg] = rm_rf (getarchdir (desc));
1009:        error ("couldn't delete directory %s: %s", getarchdir (desc), msg);
1456:  if (exist (getarchdir (desc, global_install), "dir"))
1457:    archpkg = fullfile (getarchdir (desc, global_install), nm);
1522:  octfiledir = getarchdir (desc);
1675:      rm_rf (getarchdir (desc), global_install);
1874:  tmpdir = getarchdir (desc);
2152:    tmpdir = getarchdir (desc{i});
2236:function archdir = getarchdir (desc)
2317:    tmpdir = getarchdir (installed_pkgs_lst{i});
address@hidden:~/junk>   
"

- careful examining the above one can see:

1456:  if (exist (getarchdir (desc, global_install), "dir"))
1457:    archpkg = fullfile (getarchdir (desc, global_install), nm);

, i.e. 'getarchdir' is called with _two_ arguments, the second being
'global' install. But the function has just _one_ argument.

So, what is wrong - the function or the calls ?

Thanks,
  Sergei.