Re: 3.3.54+, mkoctfile, header files?

[Olaf Till]

On Fri, Jan 14, 2011 at 12:50:21PM +0100, Olaf Till wrote:
> On Fri, Jan 14, 2011 at 06:22:51AM -0500, John W. Eaton wrote:
> > On 14-Jan-2011, Olaf Till wrote:
> > 
> > | With current (2011-01-13) Octave tip, when I try to compile something
> > | with mkoctfile, I get:
> > | 
> > | 
> > | 
> > | In file included from 
> > /usr/local/include/octave-3.3.54+/octave/../octave/oct-inttypes.h:35,
> > |                  from 
> > /usr/local/include/octave-3.3.54+/octave/../octave/idx-vector.h:35,
> > |                  from 
> > /usr/local/include/octave-3.3.54+/octave/../octave/Array.h:37,
> > |                  from 
> > /usr/local/include/octave-3.3.54+/octave/../octave/boolMatrix.h:28,
> > |                  from 
> > /usr/local/include/octave-3.3.54+/octave/../octave/mx-base.h:33,
> > |                  from 
> > /usr/local/include/octave-3.3.54+/octave/../octave/Matrix.h:31,
> > |                  from 
> > /usr/local/include/octave-3.3.54+/octave/../octave/oct.h:33,
> > |                  from test.cc:1:
> > | /usr/local/include/octave-3.3.54+/octave/../octave/lo-mappers.h: In 
> > function 'double xfloor(double)':
> > | /usr/local/include/octave-3.3.54+/octave/../octave/lo-mappers.h:37: 
> > error: 'gnulib' has not been declared
> > | 
> > | 
> > | 
> > | 
> > | The compiled file was:
> > | 
> > | 
> > | 
> > | #include <octave/oct.h>
> > | 
> > | DEFUN_DLD (test, args, , "")
> > | {
> > |   octave_value retval;
> > | 
> > |   return retval;
> > | }
> > | 
> > | 
> > | 
> > | Have the standard header files to be included for user oct-files
> > | changed, or is this a bug?
> > | 
> > | Can someone tell me what to include as a preliminary work-around? I'm
> > | not familiar with the way gnulib is integrated in Octave.
> > 
> > Does the following change avoid the problem for you?  With it, there
> > should be no gnulib:: tagged symbols in any header file in Octave.
> > 
> >   http://hg.savannah.gnu.org/hgweb/octave/rev/ab231f944252
> > 
> > jwe
> 
> I did a "hg pull" to get your patch, which pulled also some other
> patches, and now I can't compile Octave:
> 
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -I../libgnu -I../libgnu 
> -I../libcruft/misc -g -O2 -DHAVE_CONFIG_H -I/usr/include/freetype2 -Wall -W 
> -Wshadow -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings 
> -Wcast-align -Wcast-qual -g -O2 -pthread -g -O2 -MT liboctave_la-file-stat.lo 
> -MD -MP -MF .deps/liboctave_la-file-stat.Tpo -c file-stat.cc  -fPIC -DPIC -o 
> .libs/liboctave_la-file-stat.o
> file-stat.cc:33:22: error: filemode.h: No such file or directory
> file-stat.cc: In member function 'std::string 
> base_file_stat::mode_as_string() const':
> file-stat.cc:160: error: 'strmode' was not declared in this scope
> make[3]: *** [liboctave_la-file-stat.lo] Error 1
> make[3]: Leaving directory `/home/olaf/devel/src/octave/liboctave'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/home/olaf/devel/src/octave/liboctave'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/olaf/devel/src/octave'
> make: *** [all] Error 2
> 
> I'll retry now after a "make clean", but this will take 30 minutes.
> 
> Also, FYI, since my first mail had not reached address@hidden after 1
> hour, I had given the mail up and also filed a bug report (#32127).
> 
> Olaf

"make clean" did not help, but the error in building Octave changed:

libtool: link: gcc -g -O2 -pthread -DHAVE_CONFIG_H -Wall -W -Wshadow -Wformat 
-Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings 
-Wcast-align -Wcast-qual -g -O2 -pthread -pthread -g -O2 -pthread -o 
.libs/octave main.o  ./.libs/liboctinterp.so -L/usr/lib -L/usr/X11R6/lib 
/home/olaf/devel/src/octave/liboctave/.libs/liboctave.so 
../liboctave/.libs/liboctave.so 
/home/olaf/devel/src/octave/libcruft/.libs/libcruft.so 
../libcruft/.libs/libcruft.so ../libcruft/.libs/libranlib.a 
../libgnu/.libs/libgnu.a -lcholmod -lumfpack -lamd -lcamd -lcolamd -lccolamd 
-lcxsparse -larpack -lqrupdate /usr/lib/libfftw3.so /usr/lib/libfftw3f.so 
-lfltk_gl -lfltk /usr/lib/libfreetype.so /usr/lib/libhdf5.so -lpthread -lz 
-lfontconfig -lGL -lGLU -lX11 -lreadline -lncurses -lpcre -llapack -lblas -ldl 
-L/usr/lib/gcc/i486-linux-gnu/4.3.2 
-L/usr/lib/gcc/i486-linux-gnu/4.3.2/../../../../lib -L/lib/../lib 
-L/usr/lib/../lib -L/usr/lib/gcc/i486-linux-gnu/4.3.2/../../.. -lgfortranbegin 
-lgfortran -lm -pthread -Wl,-rpath -Wl,/usr/local/lib/octave-3.3.54+
/home/olaf/devel/src/octave/liboctave/.libs/liboctave.so: undefined reference 
to `strmode(unsigned int, char*)'
collect2: ld returned 1 exit status
make[3]: *** [octave] Error 1
make[3]: Leaving directory `/home/olaf/devel/src/octave/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/olaf/devel/src/octave/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/olaf/devel/src/octave'
make: *** [all] Error 2


Also tryed to transplant your patch to a compiling revision, but got
errors in building again, I don't know why.

I will test as soon as Octave builds again.

Olaf